Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a generator rather than list comprehension when using any()/all() #688

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Aug 12, 2021

SUMMARY

pylint

See also https://www.python.org/dev/peps/pep-0289/#rationale

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/aws_kms_info.py
plugins/modules/aws_ses_rule_set.py
plugins/modules/cloudwatchevent_rule.py
plugins/modules/elb_target_group.py
plugins/modules/iam.py
plugins/modules/iam_group.py
plugins/modules/iam_role.py
plugins/modules/iam_user.py
plugins/modules/rds_instance.py

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) tests tests labels Aug 12, 2021
Copy link
Member

@markuman markuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tremble tremble added the gate label Aug 13, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit d78b08c into ansible-collections:main Aug 13, 2021
@tremble tremble deleted the pylint/use-a-generator branch November 26, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants