Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route53_health_check - boto3 migration #734

Merged
merged 7 commits into from
Oct 11, 2021
Merged

route53_health_check - boto3 migration #734

merged 7 commits into from
Oct 11, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 26, 2021 •
edited
Loading

SUMMARY

route53_health_check migration to boto3

Depends-On: #746

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

route53_health_check

ADDITIONAL INFORMATION

Todo:

  • changelog
  • docs for new return values
  • tests for return values

@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @wimnat @zimbatm
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Sep 26, 2021
@tremble tremble changed the title [WIP] route53_health_check - boto3 migration route53_health_check - boto3 migration Sep 26, 2021
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Sep 26, 2021
@tremble tremble mentioned this pull request Sep 26, 2021
Closed
@tremble tremble added the gate label Oct 11, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit ff16412 into ansible-collections:main Oct 11, 2021
@tremble tremble deleted the boto3/route53_health_check branch November 26, 2021 12:45
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@goneri
setup_botocore_pip: create tempdir in /var/tmp (ansible-collections#734)
aeba19a 
setup_botocore_pip: create tempdir in /var/tmp

Depends-On: ansible/ansible-zuul-jobs#1418
Depends-On: ansible-collections#739
Depends-On: ansible-collections#739
Depends-On: ansible-collections#740
/tmp is based on ramfs and is not suitable for large files.
/var/tmp should be used instead.
See: https://fedoraproject.org/wiki/Features/tmp-on-tmpfs

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@markuman markuman Awaiting requested review from markuman

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @alinabuzachis