Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #818/bd48c164 backport][stable-2] Fix short EKS cluster names #847

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jan 5, 2022

This is a backport of PR #818 as merged into main (bd48c16).

SUMMARY

Fixes #817

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_eks

ADDITIONAL INFORMATION

Fix short EKS cluster names

SUMMARY
Fixes #817
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

aws_eks
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
(cherry picked from commit bd48c16)
@patchback patchback bot mentioned this pull request Jan 5, 2022
@markuman
Copy link
Member

markuman commented Jan 5, 2022

recheck

@markuman
Copy link
Member

markuman commented Jan 6, 2022

recheck

@marknet15
Copy link
Contributor

recheck

@markuman
Copy link
Member

recheck

@markuman markuman merged commit 0450a79 into stable-2 Jan 13, 2022
@markuman markuman deleted the patchback/backports/stable-2/bd48c1646d1ef86c1d5493e5af2d836c946b4c88/pr-818 branch January 13, 2022 07:20
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
ec2_tag - simplified 'required' logic

SUMMARY
We removed the 'list' functionality in ansible-collections#829 which now makes tags required for all states, simplify the logic.
ISSUE TYPE

Docs Pull Request
Feature Pull Request

COMPONENT NAME
plugins/modules/ec2_tag.py
ADDITIONAL INFORMATION
Not added a changelog, this rolls up into the change made for ansible-collections#829 which has its own changelog

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants