docs fix. clean up duplicated and unspecific requirements #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
Merged
… higher version already
|
Build succeeded.
|
alinabuzachis
approved these changes
Jan 17, 2022
Merged
marknet15
approved these changes
Jan 17, 2022
tremble
approved these changes
Jan 17, 2022
markuman
added
mergeit
|
Build succeeded (gate pipeline).
|
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #875 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 18, 2022
docs fix. clean up duplicated and unspecific requirements SUMMARY remove unspecific/duplicated requirements ISSUE TYPE Docs Pull Request COMPONENT NAME aws_msk_config ecs_taskdefinition ADDITIONAL INFORMATION I don't see the json library is explicit used in aws_msk_config. Furthermore it's standard python library. Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None> (cherry picked from commit ef69088)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 19, 2022
[PR #863/ef69088f backport][stable-2] docs fix. clean up duplicated and unspecific requirements This is a backport of PR #863 as merged into main (ef69088). SUMMARY remove unspecific/duplicated requirements ISSUE TYPE Docs Pull Request COMPONENT NAME aws_msk_config ecs_taskdefinition ADDITIONAL INFORMATION I don't see the json library is explicit used in aws_msk_config. Furthermore it's standard python library. Reviewed-by: Mark Woolley <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…buckets with ACL disabled. (ansible-collections#921) s3_object: Add parameter `acl_disabled` to handle uploading files to buckets with ACL disabled. SUMMARY Fixes ansible-collections#863 [Update: 07/07/2022] https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html#S3.Client.get_bucket_ownership_controls can be used to determine if ACL is disabled or not. Modified code to convert acl_disabled from a user input parameter to a variable used for testing if ACL is enabled/disabled. Add parameter acl_disabled to handle uploading files to buckets with ACL disabled. If set to true, all the permission related operations are skipped in module code. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION AWS added the option to create S3 bucket with ACL Disabled in Nov 2021) and made it the default/suggested setting when creating S3 bucket through AWS Portal . Currently the ACL "permission" parameter defaults to ["private"] and there is no way to tell the s3_object module to omit the ACL setting while uploading files to a bucket which has set the ACL as disabled. Tried looking for a way to get the existing bucket info to determine if 'ACL' is enabled/disabled, but was not able to find what I was looking for in API documentation. Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Mandar Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
I don't see the
jsonlibrary is explicit used inaws_msk_config. Furthermore it's standard python library.