aws_ssm connection: add support for SSM document #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
alinabuzachis
previously requested changes
Jan 25, 2022
blinkseb
force-pushed
the
feat-connection-ssm-document
branch
from
e259b9f
to
3705852
Compare
|
Thanks for your review! I added the changelog fragment and tried something for the integration tests |
|
Build succeeded.
|
|
@blinkseb It looks like the integration tests are currently disabled: I'm not sure of the history of the past issues and if they are resolved or not etc, but you can try running them locally to verify all is working as expected you would need to specify the |
ansibullbot
added
community_review
connection
|
Build failed.
|
blinkseb
force-pushed
the
feat-connection-ssm-document
branch
from
cc35729
to
c2792e4
Compare
|
Build failed.
|
blinkseb
force-pushed
the
feat-connection-ssm-document
branch
4 times, most recently
from
74583b7
to
ad7c800
Compare
|
Build failed.
|
blinkseb
force-pushed
the
feat-connection-ssm-document
branch
from
ad7c800
to
31af049
Compare
|
Build failed.
|
|
ok I'm progressing. I re-enabled the integration tests, like it was done in #763. I'm currently stuck with a permission error to create a new SSM document, so I opened a PR to add the necessary permissions here: mattclay/aws-terminator#192 |
This comment was marked as resolved.
This comment was marked as resolved.
|
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
|
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
|
hmmm
cc @gravesm |
|
Sure, would you mind submitting a PR for the missing policy to https://github.com/mattclay/aws-terminator? |
|
@blinkseb do you have some time to address the missing permission in a PR again? |
blinkseb
force-pushed
the
feat-connection-ssm-document
branch
from
ef54543
to
46c881b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
blinkseb
force-pushed
the
feat-connection-ssm-document
branch
from
46c881b
to
bf55002
Compare
blinkseb
force-pushed
the
feat-connection-ssm-document
branch
from
bf55002
to
6381aef
Compare
tremble
force-pushed
the
feat-connection-ssm-document
branch
2 times, most recently
from
c95c1ef
to
d343232
Compare
tremble
approved these changes
Jan 18, 2023
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1659 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
aws_ssm connection: add support for SSM document
SUMMARY
This PR adds support for SSM document to the SSM connection plugin.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
community.aws.aws_ssm
ADDITIONAL INFORMATION
The new document parameters is directly forwarded to the SSM start_session method.
Usage:
- name: Install a Nginx Package
vars:
ansible_connection: aws_ssm
ansible_aws_ssm_bucket_name: nameofthebucket
ansible_aws_ssm_region: us-west-2
ansible_aws_ssm_document: nameofthecustomdocument
tasks:
- name: Install a Nginx Package
yum:
name: nginx
state: present
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Sébastien Brochet <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit a1c35a1)
thanks a lot! |
|
@blinkseb Thanks for taking the time to submit this PR, I'm sorry it took quite so long to get everything working. With integration tests now in place hopefully we can start to clear some of the backlog around the SSM connection plugin. |
tremble
pushed a commit
that referenced
this pull request
Jan 19, 2023
aws_ssm connection: add support for SSM document
SUMMARY
This PR adds support for SSM document to the SSM connection plugin.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
community.aws.aws_ssm
ADDITIONAL INFORMATION
The new document parameters is directly forwarded to the SSM start_session method.
Usage:
- name: Install a Nginx Package
vars:
ansible_connection: aws_ssm
ansible_aws_ssm_bucket_name: nameofthebucket
ansible_aws_ssm_region: us-west-2
ansible_aws_ssm_document: nameofthecustomdocument
tasks:
- name: Install a Nginx Package
yum:
name: nginx
state: present
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Sébastien Brochet <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit a1c35a1)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
… for SSM document (#1659) [PR #876/a1c35a14 backport][stable-5] aws_ssm connection: add support for SSM document This is a backport of PR #876 as merged into main (a1c35a1). SUMMARY This PR adds support for SSM document to the SSM connection plugin. ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.aws_ssm ADDITIONAL INFORMATION The new document parameters is directly forwarded to the SSM start_session method. Usage: - name: Install a Nginx Package vars: ansible_connection: aws_ssm ansible_aws_ssm_bucket_name: nameofthebucket ansible_aws_ssm_region: us-west-2 ansible_aws_ssm_document: nameofthecustomdocument tasks: - name: Install a Nginx Package yum: name: nginx state: present Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Add integration tests for aws_resource_actions SUMMARY Add some minimal integration tests for the aws_resource_actions callback plugin. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/callback/aws_resource_actions.py ADDITIONAL INFORMATION Combined with ansible-collections#873 we've got a full set... Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds support for SSM document to the SSM connection plugin.
ISSUE TYPE
COMPONENT NAME
community.aws.aws_ssm
ADDITIONAL INFORMATION
The new document parameters is directly forwarded to the SSM
start_sessionmethod.Usage: