Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sns_topic - Add tags and purge_tags options #972

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Mar 8, 2022

SUMMARY

sns_topic - Add tags and purge_tags options

Closes #964

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sns_topic

@ansibullbot
Copy link

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) labels Mar 8, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

Copy link
Contributor

@marknet15 marknet15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@alinabuzachis
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

@alinabuzachis alinabuzachis changed the title [WIP] sns_topic - Add tags and purge_tags options sns_topic - Add tags and purge_tags options May 3, 2022
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels May 3, 2022
@github-actions
Copy link

github-actions bot commented Jun 14, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble linked an issue Jul 15, 2022 that may be closed by this pull request
1 task
@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 49s
✔️ build-ansible-collection SUCCESS in 5m 57s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 35s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 29s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 29s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 10s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 52s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 41s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 42s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 43s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 31s
✔️ ansible-test-changelog SUCCESS in 2m 16s
✔️ ansible-test-splitter SUCCESS in 2m 39s
✔️ integration-community.aws-1 SUCCESS in 6m 09s
✔️ integration-community.aws-2 SUCCESS in 5m 45s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@tremble tremble added mergeit Merge the PR (SoftwareFactory) backport-5 PR should be backported to the stable-5 branch labels Feb 1, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 49s
✔️ build-ansible-collection SUCCESS in 5m 39s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 48s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 01s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 13m 28s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 44s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 58s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 15s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 42s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 01s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 47s
✔️ ansible-test-changelog SUCCESS in 2m 14s
✔️ ansible-test-splitter SUCCESS in 2m 36s
✔️ integration-community.aws-1 SUCCESS in 6m 15s
✔️ integration-community.aws-2 SUCCESS in 5m 45s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1795e49 into ansible-collections:main Feb 1, 2023
@patchback
Copy link

patchback bot commented Feb 1, 2023

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/1795e49f98d1e1c22946806955dbc927a859086e/pr-972

Backported as #1688

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 1, 2023
sns_topic - Add tags and purge_tags options

SUMMARY

sns_topic - Add tags and purge_tags options
Closes #964

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

sns_topic

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 1795e49)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 1, 2023
…tags options (#1688)

[PR #972/1795e49f backport][stable-5] sns_topic - Add tags and purge_tags options

This is a backport of PR #972 as merged into main (1795e49).
SUMMARY

sns_topic - Add tags and purge_tags options
Closes #964

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

sns_topic

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…eys (ansible-collections#972)

 ec2_instance : Add hibernation_options and volumes->ebs->encrypted keys

Signed-off-by: GomathiselviS [email protected]
SUMMARY


May Fix ansible-collections#969
In order to support Stop-hibernate behavior for an ec2 instance the following keys are added to the ec2_instance module
"hibernation_option": true
"volumes": [
{
                "ebs": {
                    "encrypted": true
                }
            }

],
ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: GomathiselviS <None>
Reviewed-by: Mike Graves <[email protected]>
Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-5 PR should be backported to the stable-5 branch community_review feature This issue/PR relates to a feature request has_issue integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sns_topic: tagging support
4 participants