Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x509_crl_info: move main code to module_utils to allow easier implementation of diff mode #203

Merged
merged 4 commits into from
May 12, 2021
Merged

x509_crl_info: move main code to module_utils to allow easier implementation of diff mode #203

merged 4 commits into from
May 12, 2021

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Subset of #150.

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

x509_crl_info

This was referenced Mar 20, 2021
Merged
Closed
This was referenced Mar 20, 2021
Open
Closed
@felixfontein felixfontein mentioned this pull request May 12, 2021
Merged
Ajpantuso
Ajpantuso requested changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@Ajpantuso Ajpantuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functional issues as far as I can see and the added exception handling for b64decode triggered a proper module failure during my tests. Only comments are for explicit exceptions and the removal of some stale imports in the module script.

plugins/module_utils/crypto/module_backends/crl_info.py Outdated Show resolved Hide resolved
plugins/modules/x509_crl_info.py Show resolved Hide resolved
plugins/modules/x509_crl_info.py Outdated Show resolved Hide resolved
plugins/modules/x509_crl_info.py Outdated Show resolved Hide resolved
Ajpantuso
Ajpantuso approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@Ajpantuso Ajpantuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@felixfontein felixfontein merged commit 6c5a0c6 into ansible-collections:main May 12, 2021
@felixfontein felixfontein deleted the info-crl-move branch May 12, 2021 21:30
@felixfontein
Copy link
Contributor Author

@Ajpantuso thanks a lot for reviewing this :)

@renovate renovate bot mentioned this pull request Aug 25, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ajpantuso Ajpantuso Ajpantuso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @Ajpantuso