Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: drop remote CI targets for EoL Ansible/ansible-base versions; move docker CI targets for EoL Ansible/ansible-base versions to GHA #520

Merged
merged 3 commits into from
Oct 29, 2022

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Drop remote CI targets for EoL Ansible/ansible-base versions.
Move docker CI targets for EoL Ansible/ansible-base versions to GHA.

This should remove the size of the Docker image collection on AZP.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

CI

…cker CI targets for EoL Ansible/ansible-base versions to GHA.
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #520 (5cc28c9) into main (f5d98e3) will decrease coverage by 5.95%.
The diff coverage is n/a.

❗ Current head 5cc28c9 differs from pull request most recent head 12c453c. Consider uploading reports for the commit 12c453c to get more accurate results

@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   72.58%   66.62%   -5.96%     
==========================================
  Files         116       73      -43     
  Lines       12009     9835    -2174     
  Branches     2174     1842     -332     
==========================================
- Hits         8717     6553    -2164     
+ Misses       2651     2620      -31     
- Partials      641      662      +21     
Flag Coverage Δ
integration 66.37% <ø> (-5.05%) ⬇️
sanity ?
stub ?
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/plugin_utils/action_module.py
plugins/module_utils/acme/certificates.py
tests/unit/plugins/module_utils/acme/test_io.py
plugins/module_utils/crypto/module_backends/csr.py
plugins/modules/x509_crl_info.py
plugins/modules/openssl_dhparam.py
plugins/module_utils/crypto/cryptography_crl.py
plugins/doc_fragments/module_csr.py
plugins/module_utils/openssh/certificate.py
plugins/module_utils/crypto/math.py
... and 179 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixfontein
Copy link
Contributor Author

This isn't perfect (since there's no change detection), but at least it improves AZP usage.

@felixfontein
Copy link
Contributor Author

ansible-community/ansible-test-gh-action#46 adds support for change detection to the action.

It would also be useful to not always run all tests (--continue-on-error option) for integration tests. While that can be useful if coverage is computed, it makes the test take a lot longer than necessary.

@felixfontein
Copy link
Contributor Author

(Always running all tests also makes it a lot harder to find actual errors. In https://github.com/ansible-collections/community.crypto/actions/runs/3314925069/jobs/5475617923#step:3:21286 I had to scroll down thousands of lines to find the error in line 21286 out of 49914. Would be a lot easier if the error would just be at the bottom, as with AZP. Sometimes even then it's hard enough to find it if it is hidden by tons of pages shutting down the test environment...)

@felixfontein
Copy link
Contributor Author

I'm going to merge this PR as-is so we can try this out a bit...

@felixfontein felixfontein merged commit b17d57f into ansible-collections:main Oct 29, 2022
@felixfontein felixfontein deleted the ci-gha branch October 29, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant