Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update list of owners for scaleway modules #8681

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

remyleone
Copy link
Contributor

Update the list of owner of Scaleway modules

@ansibullbot
Copy link
Collaborator

@remyleone: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot ansibullbot added needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly small_patch Hopefully easy to review labels Jul 26, 2024
@ansibullbot
Copy link
Collaborator

The test botmeta failed with 2 errors:

.github/BOTMETA.yml:0:0: Author abarbare not mentioned as active or inactive maintainer for plugins/modules/scaleway_security_group.py (mentioned are: remyleone, Laure-di, DenBeke)
.github/BOTMETA.yml:0:0: Author abarbare not mentioned as active or inactive maintainer for plugins/modules/scaleway_security_group_rule.py (mentioned are: remyleone, Laure-di, DenBeke)

click here for bot help

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jul 26, 2024
@felixfontein
Copy link
Collaborator

@remyleone thanks for updating the list! Since abarbare is the (co-)author of some modules, you must list them under ignore: for at least these modules. For example:

  $modules/scaleway_:
    maintainers: $team_scaleway
    ignore: abarbare

@Laure-di can you please confirm that you want to become maintainer of the scaleway modules by approving this PR? Thanks.

@abarbare pinging you FYI, in case you disagree with being removed, please write here. If the removal is fine, there's nothing to do form your side :) In any case thanks a lot for helping to maintain the modules and (co-)authoring some of them!

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch labels Jul 26, 2024
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Aug 8, 2024
@ansibullbot
Copy link
Collaborator

@remyleone This pullrequest is waiting for you to provide the requested data in the description. Please edit the description or the pullrequest will be closed.

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch check-before-release PR will be looked at again shortly before release and merged if possible. ci_verified Push fixes to PR branch to re-run CI needs_info This issue requires further information. Please answer any outstanding questions needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly small_patch Hopefully easy to review stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants