Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxmox: [draft] Proper check for update_config #8712

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

proxmox: [draft] Proper check for update_config #8712

wants to merge 1 commit into from
+4 −0

Conversation

kaikash
Copy link

@kaikash kaikash commented Aug 4, 2024

SUMMARY

This update ensures that the configuration update check is correctly handled when the current configuration has more options than the requested configuration. Specifically, it addresses the scenario where options are being removed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.general.proxmox

@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @UnderGreen @joshainglis @karmab @krauthosting
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Aug 4, 2024
@kaikash
Copy link
Author

kaikash commented Aug 4, 2024

Hm, this seems to be an incorrect fix due to false positives, for example with net hwaddr=<mac addr>. But on the other hand, without this fix, when I remove ip6=dhcp the container is not changed. We need to handle this somehow.

@kaikash kaikash changed the title Proper check for update_config [draft] Proper check for update_config Aug 4, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch labels Aug 5, 2024
@felixfontein felixfontein changed the title [draft] Proper check for update_config proxmox: [draft] Proper check for update_config Aug 5, 2024
@felixfontein felixfontein marked this pull request as draft August 5, 2024 19:04
@felixfontein
Copy link
Collaborator

@kaikash thanks for your contribution! Please note that you need to add a changelog fragment eventually.

@ansibullbot ansibullbot added the WIP Work in progress label Aug 5, 2024
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch bug This issue/PR relates to a bug check-before-release PR will be looked at again shortly before release and merged if possible. module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review stale_ci CI is older than 7 days, rerun before merging WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaikash @ansibullbot @felixfontein