Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one_service: fix recreation #8887

Merged
merged 4 commits into from
Sep 26, 2024
Merged

one_service: fix recreation #8887

merged 4 commits into from
Sep 26, 2024

Conversation

abakanovskii
Copy link
Contributor

SUMMARY

After some investigation i concluded that the problem described in the related issue can be fixed by changing one if-statement

Fixes #3137

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

one_service

ADDITIONAL INFORMATION

I also deleted a space between a function and a body because in all other functions there is no

# Now this should work as intented
- name: Instantiating OpenNebula service
  ansible.community.one_service:
    template_id: "{{ one_template_id }}"
    service_name: "{{ deployment_name }}"
    unique: true
    wait: true

@ansibullbot
Copy link
Collaborator

cc @ilicmilan @meerkampdvv @nilsding @rsmontero @xorel
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) labels Sep 20, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch labels Sep 20, 2024
felixfontein
felixfontein reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

changelogs/fragments/8887-fix-one_service-unique.yml Outdated Show resolved Hide resolved
@felixfontein felixfontein mentioned this pull request Sep 20, 2024
Closed
1 task
@abakanovskii abakanovskii changed the title One service fix one_service: fix recreation Sep 20, 2024
russoz
russoz approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 0bc5f24 into ansible-collections:main Sep 26, 2024
147 checks passed
@patchback Patchback
Copy link

patchback bot commented Sep 26, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/0bc5f24863e98d153f89636193bba808b1f54e89/pr-8887

Backported as #8931

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 26, 2024
patchback bot pushed a commit that referenced this pull request Sep 26, 2024
@abakanovskii @patchback
one_service: fix recreation (#8887)
7355ebc 
* Fix one_service unique creation

* Revert empty space

* Add CHANGELOG fragment

* Update CHANGELOG fragment

(cherry picked from commit 0bc5f24)
@patchback patchback bot mentioned this pull request Sep 26, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Sep 26, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/0bc5f24863e98d153f89636193bba808b1f54e89/pr-8887

Backported as #8932

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@abakanovskii thanks for fixing this!
@russoz thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Sep 26, 2024
@abakanovskii @patchback
one_service: fix recreation (#8887)
845f683 
* Fix one_service unique creation

* Revert empty space

* Add CHANGELOG fragment

* Update CHANGELOG fragment

(cherry picked from commit 0bc5f24)
@patchback patchback bot mentioned this pull request Sep 26, 2024
Merged
felixfontein pushed a commit that referenced this pull request Sep 26, 2024
@patchback @abakanovskii
[PR #8887/0bc5f248 backport][stable-8] one_service: fix recreation (#…
18a8c6f 
…8931)

one_service: fix recreation (#8887)

* Fix one_service unique creation

* Revert empty space

* Add CHANGELOG fragment

* Update CHANGELOG fragment

(cherry picked from commit 0bc5f24)

Co-authored-by: alexander <[email protected]>
felixfontein pushed a commit that referenced this pull request Sep 26, 2024
@patchback @abakanovskii
[PR #8887/0bc5f248 backport][stable-9] one_service: fix recreation (#…
993d580 
…8932)

one_service: fix recreation (#8887)

* Fix one_service unique creation

* Revert empty space

* Add CHANGELOG fragment

* Update CHANGELOG fragment

(cherry picked from commit 0bc5f24)

Co-authored-by: alexander <[email protected]>
aioue pushed a commit to aioue/community.general that referenced this pull request Oct 1, 2024
@abakanovskii @aioue
one_service: fix recreation (ansible-collections#8887)
82a5ec3 
* Fix one_service unique creation

* Revert empty space

* Add CHANGELOG fragment

* Update CHANGELOG fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch bug This issue/PR relates to a bug has_issue module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenNebula one_service fails to create a service with unique name
4 participants
@abakanovskii @ansibullbot @felixfontein @russoz