-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql_role: remove redundant connection closing (fixes #329) #330
Conversation
@betanummeric hi, yes, i remember @Jorge-Rodriguez implemented that (the garbage collection), thanks for the contribution! |
Codecov Report
@@ Coverage Diff @@
## main #330 +/- ##
==========================================
- Coverage 78.25% 78.24% -0.01%
==========================================
Files 27 27
Lines 2249 2248 -1
Branches 527 527
==========================================
- Hits 1760 1759 -1
Misses 333 333
Partials 156 156
Continue to review full report at Codecov.
|
@betanummeric thanks for the contribution! |
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #332 🤖 @patchback |
…332) * mysql_role: remove redundant connection closing (fixes #329) * add changelog fragment for pull request #330 Co-authored-by: Felix Hamme <[email protected]> (cherry picked from commit 641894e) Co-authored-by: betanummeric <[email protected]>
fix #329
the connection is already closed during garbage collection: https://github.com/ansible-collections/community.mysql/blob/main/plugins/module_utils/mysql.py#L113-L116