Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql_role: remove redundant connection closing (fixes #329) #330

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

betanummeric
Copy link
Member

@Andersson007
Copy link
Collaborator

Andersson007 commented Apr 4, 2022

@betanummeric hi, yes, i remember @Jorge-Rodriguez implemented that (the garbage collection), thanks for the contribution!
Could you also please add a changelog fragment?

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #330 (15cd0e3) into main (e319ac0) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   78.25%   78.24%   -0.01%     
==========================================
  Files          27       27              
  Lines        2249     2248       -1     
  Branches      527      527              
==========================================
- Hits         1760     1759       -1     
  Misses        333      333              
  Partials      156      156              
Impacted Files Coverage Δ
plugins/modules/mysql_role.py 87.90% <ø> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e319ac0...15cd0e3. Read the comment docs.

@Andersson007 Andersson007 merged commit 641894e into ansible-collections:main Apr 5, 2022
@Andersson007
Copy link
Collaborator

@betanummeric thanks for the contribution!

@patchback
Copy link

patchback bot commented Apr 5, 2022

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/641894e6e8fa0c02384e64e7eaaaf5e5e45b82a0/pr-330

Backported as #332

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 5, 2022
* mysql_role: remove redundant connection closing (fixes #329)

* add changelog fragment for pull request #330

Co-authored-by: Felix Hamme <[email protected]>
(cherry picked from commit 641894e)
Andersson007 pushed a commit that referenced this pull request Apr 5, 2022
…332)

* mysql_role: remove redundant connection closing (fixes #329)

* add changelog fragment for pull request #330

Co-authored-by: Felix Hamme <[email protected]>
(cherry picked from commit 641894e)

Co-authored-by: betanummeric <[email protected]>
@rsicart rsicart mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mysql_role closes connection twice
3 participants