Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Test commit #474

Closed
wants to merge 1 commit into from

Conversation

Andersson007
Copy link
Collaborator

SUMMARY

Relates to #473

@Andersson007
Copy link
Collaborator Author

@felixfontein I added pull-request-change-detection: true in #473 and opened this test PR to check if now it runs only an affected target.
Seems all the targets run anyway.
Is it something unexpected or i misunderstood something?

@felixfontein
Copy link
Collaborator

@Andersson007 if you check out the sanity and unit tests, you can see that it works fine.

For the integration tests it also works fine: the tests also modify some more files https://github.com/ansible-collections/community.mysql/blob/main/.github/workflows/ansible-test-plugins.yml#L18-L19, and the changes in these files trigger all tests. So ansible-test is doing exactly what it is supposed to do when doing change detection.

@Andersson007
Copy link
Collaborator Author

@Andersson007 if you check out the sanity and unit tests, you can see that it works fine.

For the integration tests it also works fine: the tests also modify some more files https://github.com/ansible-collections/community.mysql/blob/main/.github/workflows/ansible-test-plugins.yml#L18-L19, and the changes in these files trigger all tests. So ansible-test is doing exactly what it is supposed to do when doing change detection.

Ah, thanks for clarifying:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants