Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrations tests : Use containers for more control and verify that versions match expectation #490
Integrations tests : Use containers for more control and verify that versions match expectation #490
Changes from all commits
86188a2
5bd358e
d781636
8c58068
c895a86
f2c2173
d06cefa
d98aa89
01e664f
eec9f97
574fef5
634d1fb
2149261
589a0de
60c87ab
8652a9a
cd9f216
0cd57ad
676509e
0666669
b72ca0d
4b6617a
90266f1
b821db9
c3458f4
1e03a25
87acd3d
72b3ecb
17f8ece
1c863da
405b809
7049a28
9e3010d
2af8e4f
7cffcf3
978676a
9da866a
98ce2af
1de0f2c
bc92ded
95d26fa
cb1d820
46972bb
9c1b13c
cac6af4
2efa3c4
3a12801
a271a9b
42fe4ba
a0a0493
1926808
9d3ce94
7ba0dbd
168de6b
897cb08
9872926
19e9116
10d497e
c5c32f7
163a43b
8d43f9e
1e20611
06ca921
994c6ef
9b7fbdf
9001b87
3f64fb5
0b6569d
98dbc1e
bcca4e8
7f69ead
ac74898
ae48ac7
ae0976c
4abb304
2e56d5b
f8390aa
a473e06
6adb71a
b973849
9cb404b
a3c67c3
47a4b49
d7db57c
7fc8339
ec76110
fb72e44
6710113
0494de3
ce8d166
f6e7b36
e8d7de4
a646e76
91e76d1
05a6589
ae41a50
35531e7
b9d0e96
f79355f
3f0f4ff
39de75b
4e0c048
c3e079c
7fa1bf8
85f24bd
3b379d0
3c621ea
b6160f3
4f33b77
70e23b2
199b7a5
db99524
05b5f62
79ea9fe
9bfd0a3
5bc5ed1
fbb0290
8f0d1f5
47806f1
4d2a4ff
075af8f
06ed737
73ee8f0
f9f185c
31d2905
757e974
0e5f87e
db72c79
2254e72
4547784
b24249d
6bc293a
a849f92
f663ee6
e398071
f4b1e0f
535b2f7
1aa7cc9
3686637
f52410d
fbbb700
9fd0d8b
5ba5ab0
e376b8c
eadb216
7a80607
c59e541
e908762
14cc5cc
f59e94e
05215dc
163048b
069eba9
d574daf
b2cbd3b
d6956e2
e412aa5
a5c2634
d9d48eb
20965d2
6399f24
41b408d
23dd5a5
7a0956f
5d9952c
37e5c71
cc6fdb3
a409445
095ed0a
325320a
7d50a68
d951a47
5538e17
7cfac48
ada9f6a
ff20c8c
240729d
cbc3721
31a41d1
affcd1e
39969f8
9637ec8
4fed2e2
7ec9ee5
f200382
fc66f9a
829cff6
51dc695
f39df3d
30380d5
d300f72
f1749db
84373e9
e2adefc
8658f19
fc51c78
c3a85dc
e54db90
484699b
f356eec
8f6fade
1ac543c
87b9cf0
2ce768b
5afac35
e583eb6
4ff16b7
740e3e6
8608208
0f5dc50
3bf867a
7ae5225
fedda29
eadf0a6
03a925f
9190df3
246df39
4a52201
6288c8b
41cb5de
7e2e5a3
0ef8552
2e1fbcd
cfa6b38
0cbe258
29fc0f7
1d983e9
3af4561
896ad47
f2e1bc8
ed79c6d
b6920d1
92b47c0
73ce044
b30e8d8
2462d61
a0805cc
232e9fa
5c38fc7
7218409
48da254
c0e8077
e84bbb7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laurent-indermuehle why did you go for multiple reusable workflow invocations? This causes a lot of duplication, which is prone to human error.
Besides, multiple separate workflows may fight for the resources more, aren't consolidated visually and make it hard to have unified merge gates…
Have you tried wrapping this into a matrix? I'm pretty sure this would work combined with reusable workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@webknjaz you raise a good question. I think my main goal was to rebuild the containers only if needed. Do you think it would be possible to combine a matrix and an "on: push: paths + branch_ignore: stable-*" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's 💯 possible with an extra small decision-making job that calculates conditions or even better — generates the matrix. I've been meaning to make an example PR but it fell off my radar. Maybe, later...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@webknjaz I'm finally attempting to simplify the build of the test containers as you suggested. I've done a first attempt in #643. I would love to have your input on this if you have the time.