Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #514/e2aa655 backport][stable-1] Fix issues and documentation with integration tests after merge of #490 #520

Conversation

laurent-indermuehle
Copy link
Collaborator

This is a backport of PR #514 as merged into main (e2aa655).

Add automatic selection of the docker image to use.
Revert to a test matrix instead of a list of included tests.

…sible-collections#490. (ansible-collections#514)

* Fix explanation about containers images
* Add definitive URI to the containers images
* Document that new images must be set as public
* Add makefile options possible values
* Document that any mysql and mariadb tag can be use
* Add computation of docker_image path
* Refactor pre-command to separate commands for cleaner GHA output
* Refactor to use GHA test matrix
* Cut docker_image from documentation since it's now automatic
* Document how to use run_all_test.py to display the test matrix
* Temp: Add path to images in my fork to validate integrations tests

(cherry picked from commit e2aa655)
@laurent-indermuehle laurent-indermuehle changed the title [PR #514/e2aa655 backport][stable-1] Fix issues and documentation with integration tests after merge of #490 #518 [PR #514/e2aa655 backport][stable-1] Fix issues and documentation with integration tests after merge of #490 Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #520 (60d9c32) into stable-1 (54efe0b) will decrease coverage by 2.31%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           stable-1     #520      +/-   ##
============================================
- Coverage     75.39%   73.09%   -2.31%     
============================================
  Files            23       14       -9     
  Lines          1939     1836     -103     
  Branches        474      471       -3     
============================================
- Hits           1462     1342     -120     
- Misses          334      346      +12     
- Partials        143      148       +5     
Flag Coverage Δ
integration 72.65% <ø> (ø)
sanity ?
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@laurent-indermuehle laurent-indermuehle merged commit 3e975ca into ansible-collections:stable-1 Mar 30, 2023
@laurent-indermuehle laurent-indermuehle deleted the patchback/backports/stable-1/e2aa655762a9ac5c7343a6f53e9aed1c2d86b629/pr-514 branch March 30, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant