generated from ansible-collections/collection_template
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance support of tls_requires in mysql_user and mysql_info #628
Merged
Andersson007
merged 21 commits into
ansible-collections:main
from
laurent-indermuehle:lie_test_require_ssl
Apr 16, 2024
Merged
Enhance support of tls_requires in mysql_user and mysql_info #628
Andersson007
merged 21 commits into
ansible-collections:main
from
laurent-indermuehle:lie_test_require_ssl
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent-indermuehle
changed the title
Lie test require ssl
Enhance support of tls_requires in mysql_user and mysql_info
Apr 12, 2024
I think I'm ready for a review. If anyone is motivated it will be appreciated! In the meantime, have a nice week-end everyone! |
Andersson007
approved these changes
Apr 16, 2024
@laurent-indermuehle thanks a lot for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I refactored the
get_tls_requires
method with separate implementations for MySQL and MariaDB.The solution for MariaDB turned out to be incompatible with MySQL.
I fixed the integration tests for
mysql_info
and added test users with TLS to assert that everything is working correctly.This chang enable using the output of
mysql_info: {filter: users_info}
and passing it tomysql_user
to achieve idempotent execution even if the user has TLS options.I encountered an issue with MySQL 8 refusing to remove SSL and X509 when
tls_requires
was passed an empty value. I'm unsure why this test passed previously. Perhaps it was due to adding a sanitized method during this PR? I admit that I didn't put much effort into MySQL (even though it consumes 80% of my time...). I hope I successfully fixed that too.ISSUE TYPE
COMPONENT NAME
mysql_user, mysql_info
EXEMPLES
Using
mysql_info
with community.mysql 3.9.0:Using
mysql_info
with this PR: