-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Remove ansible-test custom containers #650
[CI] Remove ansible-test custom containers #650
Conversation
yeah, it'd be great if we use that default container only:) |
ignore_errors is bad because it makes searching for real errors difficult.
Green, finally! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laurent-indermuehle looks like a great simplification! Thanks! You're a CI grand-guru:)
After we drop mysqlclient it'll get significantly faster, looking forward to it |
@Andersson007 Yes and no, thanks to parallel execution on GHA. But we will use less resources for sure. |
sure, if you create it you can:) |
SUMMARY
This pull request aims to simplify our testing setup by removing custom test containers and using the default container provided by
ansible-test
.Background
The current setup requires building custom test containers and cleaning up the registry manually, which is complex, especially for those not familiar with the system's initial implementation.
Changes Introduced
ansible-community/ansible-test-gh-action
.Important Notes
ansible-test
containers, was to use MySQL/MariaDB containers instead ofdbinstaller
. This PR does not alter that setup.Benefits
controller_setup
clearly states what is installed in the test container. No need to check the Containerfile in the hidden folder.github
. Also, this allows using Ansible instead of bash, again simplifying things.Risks
I believe the difference in Ubuntu images is a non-issue. We don't test Ubuntu here, and as long as all the test components are working in both environments, the job is done.
I don't see an easy way to align versions used:
make
startsansible-test
with--docker
from a Python venv. If the container version is forced using--target docker:ubuntu2204
, then Python 3.10 is forced too. With thedefault
container, all versions of Python are available (2.7 to 3.12 as of today).ansible-test
without the--docker
option.Unless someone sees a way to make this more consistent between the two test methods, I propose to let this be as is and deal with it again when
ansible-test
changes its default container.ISSUE TYPE
COMPONENT NAME