Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql_variables: fix boolean value handling #653

Merged
merged 8 commits into from
Jun 28, 2024

Conversation

Andersson007
Copy link
Collaborator

SUMMARY

Fixes #652

@Andersson007 Andersson007 marked this pull request as draft June 27, 2024 09:05
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.36%. Comparing base (0bc3e3d) to head (b526a42).
Report is 4 commits behind head on main.

Current head b526a42 differs from pull request most recent head 258eeba

Please upload reports for the commit 258eeba to get more accurate results.

Files Patch % Lines
plugins/modules/mysql_variables.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #653       +/-   ##
===========================================
+ Coverage   23.87%   72.36%   +48.48%     
===========================================
  Files          29       16       -13     
  Lines        2739     2573      -166     
  Branches      687      666       -21     
===========================================
+ Hits          654     1862     +1208     
+ Misses       2025      488     -1537     
- Partials       60      223      +163     
Flag Coverage Δ
integration 72.28% <87.50%> (?)
sanity ?
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andersson007 Andersson007 marked this pull request as ready for review June 28, 2024 08:40
@Andersson007 Andersson007 merged commit 4912f1a into ansible-collections:main Jun 28, 2024
43 checks passed
@Andersson007
Copy link
Collaborator Author

@laurent-indermuehle thanks for helping with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mysql_variables always changes on boolean values
2 participants