Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vmware_guest idempotency when using dvswitch (fixes #498) #2000

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Yannik
Copy link
Contributor

@Yannik Yannik commented Feb 16, 2024

SUMMARY

This fixes the idempotency issue reported in #498 caused by nic.device.deviceInfo.summary containing DVSwitch: d5 6e 22 50 dd f2 94 7b-a6 1f b2 c2 e6 aa 0f instead of a readable portgroup name.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_guest

@Yannik Yannik force-pushed the fix-idempotency-with-dvswitch branch 2 times, most recently from b4f47f8 to 7fc61f6 Compare February 16, 2024 16:40
@Yannik Yannik force-pushed the fix-idempotency-with-dvswitch branch from 92da7f8 to b385e03 Compare September 12, 2024 06:45
@Yannik
Copy link
Contributor Author

Yannik commented Sep 12, 2024

@mariolenz Would it be possible to get this merged? Thanks!

@mariolenz
Copy link
Collaborator

Sorry, I've overlooked this PR for far too long. I think we had some changes to the module. Could you please re-base your fork just to make sure there are no merge conflicts?

@Yannik Yannik force-pushed the fix-idempotency-with-dvswitch branch from b385e03 to 9dd08fe Compare October 29, 2024 17:46
@Yannik
Copy link
Contributor Author

Yannik commented Oct 29, 2024

@mariolenz Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants