Fix vmware_guest_serial_port to have idempotency #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
sky-joker
force-pushed
the
fix_vmware_guest_serial_port
branch
from
f12c483
to
9c2e40d
Compare
sky-joker
changed the title
sky-joker
force-pushed
the
fix_vmware_guest_serial_port
branch
from
9c2e40d
to
254a235
Compare
add changelog file update integration test update integration test
sky-joker
force-pushed
the
fix_vmware_guest_serial_port
branch
from
254a235
to
0907df3
Compare
goneri
approved these changes
Aug 24, 2020
goneri
reviewed
Aug 24, 2020
| - choices: | ||
| - client | ||
| - server' | ||
| - ' - C(no_rx_loss) (bool): Required when I(backing_type=pipe). | ||
| Enables optimized data transfer over the pipe. |
There was a problem hiding this comment.
VMware's default seems to be False. Can we set it False by default too?
There was a problem hiding this comment.
Thank you for your comment!
I'll work on it :)
There was a problem hiding this comment.
I changed the no_rx_loss default value to False.
goneri
requested changes
Aug 25, 2020
| @@ -0,0 +1,2 @@ | |||
| minor_changes: | |||
| - vmware_guest_serial_port - fixed to have idepomtency(https://github.com/ansible-collections/vmware/pull/358). | |||
There was a problem hiding this comment.
In order to be sure everybody understand, I would avoid the world idempotency ( not idepomtency :-) ) and just say: ensure we can run the module two times in a row without unexpected side effect.
There was a problem hiding this comment.
Thank you for your advice.
I modified the changelog file that way!
goneri
removed
the
needs_triage
|
Thank you @sky-joker! |
goneri
reviewed
Aug 26, 2020
The required_if-unknown-key error occurs caused is I set wronged first key(alias) in the required_if list.
|
Thank you @goneri :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is to fix vmware_guest_serial_port to have idempotency.
Also, fix some documents.
fixes: #343
ISSUE TYPE
COMPONENT NAME
plugins/modules/vmware_guest_serial_port.py
ADDITIONAL INFORMATION
tested on vCenter/ESXi 7.0