Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to split the variables setting process by determining whether it … #368

Conversation

sky-joker
Copy link
Collaborator

@sky-joker sky-joker commented Aug 29, 2020

SUMMARY

This PR is to fix the variables setting process by determining whether it is LinuxPrep or SysPrep in the vmware_guest_customization_info module.
And fix the ip_address variable default value is to set None if it has not an attribute.

fixes: #360

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/vmware_guest_customization_info

ADDITIONAL INFORMATION

tested on vCenter7.0

@sky-joker sky-joker changed the title [WIP] Fix to split the variables setting process by determining whether it … Fix to split the variables setting process by determining whether it … Aug 29, 2020
@sky-joker
Copy link
Collaborator Author

@Akasurde @goneri

When you have time, can you please look at this PR?

@goneri goneri added the gate label Sep 14, 2020
@ansible-zuul ansible-zuul bot merged commit befd051 into ansible-collections:main Sep 14, 2020
@sky-joker
Copy link
Collaborator Author

Thank you @goneri :)

@sky-joker sky-joker deleted the fix_vmware_guest_customization_info branch September 14, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

customization_info vcenter 6.7 no attribute hostName
2 participants