Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new module vmware_host_iscsi_info #402

Merged

Conversation

sky-joker
Copy link
Collaborator

SUMMARY

This PR adds a new module vmware_host_iscsi_info.

related comment: #224 (comment)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/vmware_host_iscsi_info.py

ADDITIONAL INFORMATION

tested on vSphere 6.7

Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

plugins/modules/vmware_host_iscsi_info.py Outdated Show resolved Hide resolved
@Akasurde Akasurde added the new_module New module label Sep 28, 2020
@Akasurde Akasurde self-requested a review September 28, 2020 12:44
@sky-joker
Copy link
Collaborator Author

@Akasurde

Can I merge this PR?

@Akasurde Akasurde added the gate label Sep 30, 2020
@ansible-zuul ansible-zuul bot merged commit 10b9762 into ansible-collections:main Sep 30, 2020
@sky-joker
Copy link
Collaborator Author

Thank you @Akasurde !

@sky-joker sky-joker deleted the add_vmware_host_iscsi_info branch September 30, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new_module New module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants