Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_drs_group: code refactor #475

Merged
merged 1 commit into from
Nov 22, 2020
Merged

vmware_drs_group: code refactor #475

merged 1 commit into from
Nov 22, 2020

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Nov 3, 2020 •
edited
Loading

SUMMARY

code refactor

Signed-off-by: Abhijeet Kasurde [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/81_vmware_drs_group.yml
plugins/modules/vmware_drs_group.py

@Akasurde Akasurde mentioned this pull request Nov 3, 2020
Closed
@Akasurde
Copy link
Member Author

Akasurde commented Nov 3, 2020

recheck

@Akasurde Akasurde added feature_request New feature or request has_issue labels Nov 3, 2020
goneri
goneri requested changes Nov 3, 2020
View reviewed changes
plugins/modules/vmware_drs_group.py Outdated Show resolved Hide resolved
@Akasurde Akasurde changed the title vmware_drs_group: Manage existing members in DRS group vmware_drs_group: code refactor Nov 20, 2020
@Akasurde Akasurde added this to the v.1.5.0 milestone Nov 20, 2020
@Akasurde Akasurde requested a review from goneri November 20, 2020 06:36
mariolenz
mariolenz approved these changes Nov 21, 2020
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akasurde Akasurde added the gate label Nov 22, 2020
@ansible-zuul ansible-zuul bot merged commit c86e350 into ansible-collections:main Nov 22, 2020
@Akasurde Akasurde deleted the i81 branch November 23, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

@dericcrago dericcrago Awaiting requested review from dericcrago

@sky-joker sky-joker Awaiting requested review from sky-joker

@goneri goneri Awaiting requested review from goneri

Assignees
No one assigned
Labels
feature_request New feature or request has_issue
Projects
None yet
Milestone
v.1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Akasurde @goneri @mariolenz