vmware_deploy_ovf: Fix the issue that the name variable referenced error occurs #499
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky-joker
changed the title
mariolenz
reviewed
Nov 13, 2020
| @@ -0,0 +1,2 @@ | |||
| bugfixes: | |||
| - vmware_deploy_ovf - fixed the issue that the name variable referenced error occurs when the check mode (https://github.com/ansible-collections/community.vmware/pull/499). | |||
There was a problem hiding this comment.
Suggested change
| - vmware_deploy_ovf - fixed the issue that the name variable referenced error occurs when the check mode (https://github.com/ansible-collections/community.vmware/pull/499). | |
| - vmware_deploy_ovf - Fixed an UnboundLocalError for variable 'name' in check mode (https://github.com/ansible-collections/community.vmware/issues/497). |
There was a problem hiding this comment.
Thank you for reviewing!
The start seems we need to start with lowercase letters.
#461 (comment)
|
@sky-joker The bugfix looks good to me. But I've suggested an improvement to the changelog fragment. Can you please have a look at it? |
|
@mariolenz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The vmware_deploy_ovf module occurs the name variable referenced error when the check mode.
This PR is to fix the above issue.
fixes: #497
ISSUE TYPE
COMPONENT NAME
plugins/modules/vmware_deploy_ovf.py
ADDITIONAL INFORMATION
tested on vCenter/ESXi 7.0