Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_drs_group_manager: new module #512

Merged
merged 1 commit into from
Jan 29, 2021
Merged

vmware_drs_group_manager: new module #512

merged 1 commit into from
Jan 29, 2021
+1,035 −5

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Nov 20, 2020 •
edited by mariolenz
Loading

Depends-On: #620

SUMMARY

Fixes: #81

Signed-off-by: Abhijeet Kasurde [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

README.md
docs/community.vmware.vmware_drs_group_manager_module.rst
meta/runtime.yml
plugins/modules/vmware_drs_group_manager.py

@Akasurde Akasurde added this to the v.1.5.0 milestone Nov 20, 2020
@Akasurde Akasurde mentioned this pull request Nov 20, 2020
Closed
@Akasurde
Copy link
Member Author

@vMarkusK @danielmhi @richardlock @alexsuppanz Could you please check this new module and provide your feedback? Thanks.

@richardlock
Copy link

richardlock commented Nov 20, 2020 •
edited
Loading

Hi @Akasurde. Thanks for the work on this. I tested it and it successfully added/removed a single VM and then multiple VMs from a DRS VM group.

@Akasurde
Copy link
Member Author

@richardlock Sweet. Thanks for testing this so quickly.

@richardlock
Copy link

Hi. Is there anything else required before accepting the pull request? Thanks.

goneri
goneri requested changes Dec 2, 2020
View reviewed changes
Copy link
Member

@goneri goneri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, can you add a functional test to the PR?

plugins/modules/vmware_drs_group_manager.py Outdated Show resolved Hide resolved
@Akasurde Akasurde force-pushed the vmware_drs_group_manager branch 2 times, most recently from 47caba2 to cddc8e9 Compare December 3, 2020 04:29
@Akasurde Akasurde modified the milestones: v.1.5.0, v1.6.0 Dec 7, 2020
@Akasurde
Copy link
Member Author

Akasurde commented Dec 8, 2020

recheck

@Akasurde
Copy link
Member Author

Akasurde commented Dec 9, 2020

recheck

@danielmhi
Copy link

@Akasurde. Sorry for the delay, I've tested it and it successfully added/removed a single VM and then multiple VMs from a DRS VM group.

Thanks for this

@vMarkusK
Copy link

vMarkusK commented Jan 5, 2021

Add to existing group (my initial requirement) works fine.

  • VMware vSphere 6.7 Update 3

@Akasurde Akasurde modified the milestones: v1.6.0, v1.7.0 Jan 6, 2021
@Akasurde
Copy link
Member Author

Akasurde commented Jan 7, 2021

recheck

4 similar comments
@Akasurde
Copy link
Member Author

recheck

@goneri
Copy link
Member

goneri commented Jan 11, 2021

recheck

@sky-joker
Copy link
Collaborator

recheck

@Akasurde
Copy link
Member Author

recheck

@ansibullbot
Copy link

cc @Tomorrow9 @lparkes @pgbidkar @warthog9
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug cloud community_review docs integration tests/integration module module new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Jan 15, 2021
@Akasurde
Copy link
Member Author

recheck

1 similar comment
@Akasurde
Copy link
Member Author

recheck

@Akasurde
Copy link
Member Author

cc @goneri Could you please check CI failures? Thanks.

@Akasurde
Copy link
Member Author

recheck

3 similar comments
@Akasurde
Copy link
Member Author

recheck

@Akasurde
Copy link
Member Author

recheck

@mariolenz
Copy link
Collaborator

recheck

@Akasurde Akasurde mentioned this pull request Jan 27, 2021
Closed
mariolenz
mariolenz requested changes Jan 27, 2021
View reviewed changes
plugins/modules/vmware_drs_group_manager.py Show resolved Hide resolved
plugins/modules/vmware_drs_group_manager.py Outdated Show resolved Hide resolved
plugins/modules/vmware_drs_group_manager.py Outdated Show resolved Hide resolved
plugins/modules/vmware_drs_group_manager.py Outdated Show resolved Hide resolved
@goneri
Copy link
Member

goneri commented Jan 28, 2021

recheck

@Akasurde Akasurde added the gate label Jan 29, 2021
@ansible-zuul ansible-zuul bot merged commit 2a2ae57 into ansible-collections:main Jan 29, 2021
@Akasurde Akasurde deleted the vmware_drs_group_manager branch January 29, 2021 05:54
@richardlock
Copy link

Thanks for adding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneri goneri goneri requested changes

@mariolenz mariolenz mariolenz requested changes

@sky-joker sky-joker Awaiting requested review from sky-joker

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug cloud community_review docs has_issue integration tests/integration module module new_module_request New module request new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

vmware_drs_group - Add VM to DRS Group
8 participants
@Akasurde @richardlock @danielmhi @vMarkusK @goneri @sky-joker @ansibullbot @mariolenz