Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_host: add a new state option the disconnected #589

Merged

Conversation

sky-joker
Copy link
Collaborator

@sky-joker sky-joker commented Dec 29, 2020

SUMMARY

This PR will add a new state option(disconnected) to the vmware_host module.
By supporting the disconnected option, we can execute new integration tests for the disconnected state host.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

docs/community.vmware.vmware_host_module.rst
plugins/modules/vmware_host.py
tests/integration/targets/vmware_host/tasks/main.yml

ADDITIONAL INFORMATION

tested vCenter/ESXi 6.7

@sky-joker sky-joker changed the title [WIP] vmware_host: add a new state option the disconnected vmware_host: add a new state option the disconnected Dec 29, 2020
@sky-joker
Copy link
Collaborator Author

recheck

1 similar comment
@mariolenz
Copy link
Collaborator

recheck

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariolenz mariolenz added the gate label Dec 31, 2020
@ansible-zuul ansible-zuul bot merged commit 358a5ce into ansible-collections:main Dec 31, 2020
@sky-joker
Copy link
Collaborator Author

Thank you @mariolenz

@sky-joker sky-joker deleted the add_state_option_vmware_host branch December 31, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants