-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump ansible versions #605
Conversation
This reverts commit 3f44909.
Upgrading versions led to a much more finicky linter. Nearly all of the changes in this huge PR are fixes for linter complaints about YAML formatting and unused Python imports. The files with meaningful (i.e., useful to review) changes are: .github/workflows/* The changes in those files are what led to the fixes in all the other files. With this PR all of the unit, integration, and lint tests pass. The next (and hopefully final) steps will be to tag this commit as the new release, update the metadata with the new version, and push it to Automation Hub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me! I read the top-level stuff and skimmed the actual test configs.
@@ -9,15 +9,15 @@ lint: | | |||
ansible-lint | |||
platforms: | |||
- name: instance | |||
image: ubuntu:18.04 | |||
image: ubuntu:20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 22:04?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Baby steps - on the role tests I started by upgrading the EOLD'd Debian 9 to to the current Debian 12 which didn't work and was going to require a ton of changes (to the tests, that is), then to 11 (ditto) and finally to 10 (still supported for a little while) which worked. Ubuntu 22.04 will probably work, but I'm being conservative for now.
Upgrade minimum Ansible version to 2.14; test against 2.14 and 2.15.