Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ansible versions #605

Merged
merged 15 commits into from
Nov 21, 2023
Merged

chore: bump ansible versions #605

merged 15 commits into from
Nov 21, 2023

Conversation

SirGitsalot
Copy link
Collaborator

Upgrade minimum Ansible version to 2.14; test against 2.14 and 2.15.

@SirGitsalot
Copy link
Collaborator Author

Upgrading versions led to a much more finicky linter. Nearly all of the changes in this huge PR are fixes for linter complaints about YAML formatting and unused Python imports. The files with meaningful (i.e., useful to review) changes are:

.github/workflows/*
meta/runtime.yml

The changes in those files are what led to the fixes in all the other files.

With this PR all of the unit, integration, and lint tests pass. The next (and hopefully final) steps will be to tag this commit as the new release, update the metadata with the new version, and push it to Automation Hub.

Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me! I read the top-level stuff and skimmed the actual test configs.

@@ -9,15 +9,15 @@ lint: |
ansible-lint
platforms:
- name: instance
image: ubuntu:18.04
image: ubuntu:20.04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 22:04?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baby steps - on the role tests I started by upgrading the EOLD'd Debian 9 to to the current Debian 12 which didn't work and was going to require a ton of changes (to the tests, that is), then to 11 (ditto) and finally to 10 (still supported for a little while) which worked. Ubuntu 22.04 will probably work, but I'm being conservative for now.

@SirGitsalot SirGitsalot merged commit fadb559 into master Nov 21, 2023
9 checks passed
@SirGitsalot SirGitsalot deleted the upgrade-ansible-versions branch November 21, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants