-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s_exec: Select first container from the pod #363
k8s_exec: Select first container from the pod #363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Could you also add a test for a pod with two containers?
yes sure |
recheck |
This comment was marked as duplicate.
This comment was marked as duplicate.
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
kubectl command select first container from the pod in order to execute commands on. We replicate the same behavior in k8s_exec module. Fixes: ansible-collections#358 Signed-off-by: Abhijeet Kasurde <[email protected]>
Build succeeded.
|
mergeit |
1 similar comment
mergeit |
regate |
mergeit |
Build failed.
|
recheck |
mergeit |
I didn't check out the code, but this looks like this will solve my issue, thanks! #358 |
Thanks for the feedback. |
SUMMARY
kubectl command select first container from the pod in order
to execute commands on. We replicate the same behavior in k8s_exec
module.
Fixes: #358
Signed-off-by: Abhijeet Kasurde [email protected]
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/358-k8s_exec.yml
plugins/modules/k8s_exec.py