Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Helm post-renderer #403

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Added support for Helm post-renderer #403

merged 2 commits into from
Mar 31, 2022

Conversation

mnaser
Copy link
Contributor

@mnaser mnaser commented Mar 11, 2022

SUMMARY

Add support for Helm post renderer

Fixes: #30

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

helm

ADDITIONAL INFORMATION

@softwarefactory-project-zuul
Copy link

Build succeeded.

Akasurde
Akasurde requested changes Mar 29, 2022
View reviewed changes
changelogs/fragments/30-helm-add-post-renderer-support.yml Outdated Show resolved Hide resolved
plugins/modules/helm.py Show resolved Hide resolved
plugins/modules/helm.py Outdated Show resolved Hide resolved
@mnaser @Akasurde
Apply suggestions from code review
b7515dc 
Co-authored-by: Abhijeet Kasurde <[email protected]>
@softwarefactory-project-zuul
Copy link

Build failed.

@Akasurde
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

@Akasurde
Copy link
Member

@gravesm Can you please take a look? Thanks

gravesm
gravesm approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnaser Thank you for the PR!

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2c96b70 into ansible-collections:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akasurde Akasurde Akasurde approved these changes

@gravesm gravesm gravesm approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm Post Rendering support
3 participants
@mnaser @Akasurde @gravesm