[PR #745/6a04f42d backport][stable-5] helm: Accept release candidate versions for compatibility checks #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
SUMMARY If the helm CLI version includes -rc.1 for example, the version checks fails due to an incomplete regex. The error can be triggered if you use helm v3.15.0-rc.1 for example, and apply a helm chart with wait: true ISSUE TYPE Bugfix Pull Request COMPONENT NAME helm helm_pull ADDITIONAL INFORMATION Reviewed-by: Yuriy Novostavskiy Reviewed-by: Eric G. Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 6a04f42)
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 35s |
gravesm
approved these changes
Jun 18, 2024
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 34s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #745 as merged into main (6a04f42).
SUMMARY
If the helm CLI version includes
-rc.1for example, the version checks fails due to an incomplete regex.The error can be triggered if you use helm v3.15.0-rc.1 for example, and apply a helm chart with
wait: trueISSUE TYPE
COMPONENT NAME
helm
helm_pull
ADDITIONAL INFORMATION