-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use ansible-test's change detection for Pull Requests #46
Merged
webknjaz
merged 12 commits into
ansible-community:main
from
felixfontein:change-detection
Nov 14, 2022
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
05aa9e9
Implement basic change detection.
felixfontein 20da3b3
Remove quotes.
felixfontein 79b4a18
Revert "Remove quotes."
felixfontein 17eb7ed
Update README.
felixfontein 4a45c4a
Try to add test case.
felixfontein b5820dc
Reduce line length.
felixfontein 54e5295
Revert "Reduce line length." and "Try to add test case."
felixfontein 0331670
Try tests again.
felixfontein b40aa9f
Improve branch naming.
felixfontein 68c8263
Only copy collection when really necessary.
felixfontein 1c9d960
The irongut/CodeCoverageSummary action does not like absolute paths.
felixfontein 5241d0a
Document additional requirement.
felixfontein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to have this on by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a breaking change, and different what most collections do right now. Basically only the collections using AZP use change detection, all others simply run all tests.
Also switching this on effectively disables code coverage reporting for pull requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explore if codecov's carryforward feature could fix this?