Only copy collection when really necessary #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @webknjaz |
webknjaz
reviewed
Nov 14, 2022
| COLLECTION_META_FILE = 'galaxy.yml' | ||
| with open(COLLECTION_META_FILE) as galaxy_yml: | ||
| with open(os.path.join(directory, COLLECTION_META_FILE)) as galaxy_yml: |
There was a problem hiding this comment.
Since this is running on a modern enough Python, maybe it's time to just use pathlib?
This all could be as simple as
from pathlib import Path
...
galaxy_yml_path = Path(directory / COLLECTION_META_FILE)
galaxy_yml_text = galaxy_yml_path.read_text()
collection_meta = yaml.loads(galaxy_yml_text)
webknjaz
approved these changes
Nov 14, 2022
|
@webknjaz thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subset of #46 that is not really related to change detection.
Avoid copying the part of the repository that contains the collection if the correct filesystem structure is already present. This ensures that the git repository data is kept intact.