Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to control code coverage #50

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Nov 27, 2022

Contains #49. Will rebase once that is merged. (That is now done.)

Provides a new option coverage with values always, never, and auto. The behavior for auto is to not send code coverage when pull-request-change-detection=true and the action is called from a PR; this can be adjusted later (ref: #46 (comment), #46 (comment)).

@felixfontein
Copy link
Contributor Author

This is now ready for review.

@felixfontein
Copy link
Contributor Author

@webknjaz any chance that you could review this?

action.yml Outdated Show resolved Hide resolved
action.yml Show resolved Hide resolved
@felixfontein
Copy link
Contributor Author

#54 should fix broken CI.

@webknjaz webknjaz merged commit c2f3a12 into ansible-community:main Jan 3, 2023
@felixfontein felixfontein deleted the coverage branch January 3, 2023 07:28
@felixfontein
Copy link
Contributor Author

@webknjaz thanks for reviewing and merging!

@gardar
Copy link

gardar commented Jan 11, 2023

Any chance there will be a new release that includes this option published soon?
It's a bit confusing that the documentation over at https://github.com/marketplace/actions/ansible-test already has the coverage option listed when it's not available in a released version. (I know I can use the branch or commit in my workflow, but still).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants