Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in use audit with goss >0.4.x #53

Open
sysop200 opened this issue Oct 5, 2023 · 9 comments
Open

bug in use audit with goss >0.4.x #53

sysop200 opened this issue Oct 5, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@sysop200
Copy link

sysop200 commented Oct 5, 2023

There are plans to rework the audit to work with goss version >0.4.x
When using version >0.4.x, the field does not contain the correct queries:
"matcher-result": {

"Actual": "object: *bytes.Reader",

"Expected": [
"/^MaxAuthTries [1-4]/",
"!/^MaxAuthTries [5-9]/"
],
"ExtraElements": null,
"Message": "to have patterns",
"MissingElements": [
"/^MaxAuthTries [1-4]/"

created an issue in the developer's repository
goss-org/goss#845

@sysop200 sysop200 added the bug Something isn't working label Oct 5, 2023
@uk-bolly uk-bolly self-assigned this Oct 10, 2023
@uk-bolly
Copy link
Member

hi @sysop200

Thank you for raising this issue. We are currently working on other repositories. We are aware of the 0.4 change.
We have already rewritten one audit to allow this to work.
I will test and look at this further and discuss with goss owner to go through with them.

Many thanks

uk-bolly

@sysop200
Copy link
Author

Hi, I am very glad that this is not only my problem and you are also interested in it. I will wait for this decision.
Best regards!

@sysop200
Copy link
Author

Hmm... With the new version of goss this test does not work at all. it's a pity. We need to review all the tests again.
audit_sysop.4check.ru_1700413601.json

@uk-bolly
Copy link
Member

uk-bolly commented Nov 21, 2023 via email

@sysop200
Copy link
Author

I do not insist. Thank you so much for the inspiration with your set of scripts. Very necessary in the work of a security officer

@uk-bolly
Copy link
Member

hi @sysop200

Apologies it has taken so long to get back to you. There was a new release of CIS shortly after our discussion, there is a new benchmark v3.0, which required an almost complete rewrite of both this audit and the remediate this is compatible with the 0.4x version of the goss binary.

Kindest regards

uk-bolly

@sysop200
Copy link
Author

Thanks a lot! I had to edit the configurations myself. But I’ll take your version and compare it with mine again, maybe I missed any mistakes on my part. There is a very lack of language support. I'm working on it now.

@uk-bolly
Copy link
Member

hi @sysop200

Ive seen the discussions on the goss repo. We happy to close this issue off, while the source is fixed?

many thanks

uk-bolly

@uk-bolly
Copy link
Member

HI @sysop200

Great update from on the goss issue. Looks like a fix that we can try to add in. goss-org/goss#845

Already got the ball rolling internally to assign the time.

Will try and make this the first repo and see how we get on.

Thanks

uk-bolly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants