Skip to content
This repository has been archived by the owner on Mar 23, 2019. It is now read-only.

Improved client timeout #318

Merged
merged 1 commit into from
Nov 19, 2016
Merged

Improved client timeout #318

merged 1 commit into from
Nov 19, 2016

Conversation

chouseknecht
Copy link
Contributor

@chouseknecht chouseknecht commented Nov 19, 2016 •
edited
Loading

ISSUE TYPE
  • Bugfix Pull Request
SUMMARY

Refining fix for #147.
Addresses issue raised on #315

  • Adds support for COMPOSE_HTTP_TIMEOUT, as it appears compose is deprecating support for DOCKER_CLIENT_TIMEOUT
  • Casts value received from either COMPOSE_HTTP_TIMEOUT or DOCKER_CLIENT_TIMEOUT to int
  • Gracefully handles errors arising from a non-integer value

Use COMPOSE_HTTP_TIMEOUT. Cast timeout to int.
aa3c843 
- If DOCKER_CLIENT_TIMEOUT not set, check COMPOSE_HTTP_TIMEOUT
- DOCKER_CLIENT_TIMEOUT is deprecated by compose
- Cast timeout value to int, and gracefully handle ValueError
@chouseknecht chouseknecht mentioned this pull request Nov 19, 2016
Closed
@chouseknecht chouseknecht merged commit 8cf1d8a into ansible:develop Nov 19, 2016
@chouseknecht chouseknecht mentioned this pull request Nov 19, 2016
Merged
@marcusianlevine marcusianlevine mentioned this pull request Jul 14, 2017
Closed
This was referenced Jul 22, 2017
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chouseknecht