This repository has been archived by the owner on Mar 23, 2019. It is now read-only.
Pull missing images during build #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
Fixes #400
During the build process, attempt to pull missing images. Images will be pulled from the engine's default registry. If using the default engine, Docker, then images will be pulled from Docker Hub. If this is not desired, then at this point, it's incumbent on the user to pull the images manually prior to running the build process.
It may be possible, although not tested, for a registry to be included in the
fromdirective, and if credentials exist in the default registry auth file (e.g. ~/.docker/config.json), for the images to be pulled from a private registry. This PR does mount the default auth file to the conductor, making it available to thepullprocess.