Skip to content
This repository has been archived by the owner on Mar 23, 2019. It is now read-only.

Require the Docker >= 2.4.0 Python library (#564) #702

Merged

Conversation

LukeShortCloud
Copy link
Contributor

ISSUE TYPE
  • Bugfix Pull Request
SUMMARY

A bug in the Python library "docker" before 2.4.0 prevented images from correctly being used as docker would always look for the name "a"

Fixes #564

@chouseknecht
Copy link
Contributor

@ekultails

Thank you for working on this. Contributions are always appreciated!

I don't think we want to add docker to the requirements.txt. Instead, we should update setup.py, here and here.

@LukeShortCloud
Copy link
Contributor Author

Hey Chris, thanks for pointing that out! I went ahead and corrected that. Let me know if anything else should be tweaked.

@chouseknecht
Copy link
Contributor

LGTM. Thanks @ekultails!

@chouseknecht chouseknecht merged commit e3dd686 into ansible:develop Aug 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 Client Error: Not Found ("No such image: a")
2 participants