Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github Action to label issues and PRs #118

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Add Github Action to label issues and PRs #118

merged 4 commits into from
Jul 25, 2023

Conversation

gotmax23
Copy link
Collaborator

@gotmax23 gotmax23 commented Jul 14, 2023 •
edited
Loading

This script adds an sc_approval label to all PRs that touch files owned by @ansible/steering-committee in CODEOWNERS. It also add a needs_triage label to new issues and PRs.

This is based on discussion with @samccann and @felixfontein in #ansible-docs earlier today.

This script is relatively simple, but we should be able to easily expand it to add other labels or do other types of triage.

Relates: #101

@samccann
Copy link
Contributor

+1 . I can't really 'review' cuz I barely follow the code but I agree with the strategy.

@gotmax23
Copy link
Collaborator Author

On request from @samccann, I updated this to also add needs_triage labels to new issues and PRs. I refactored the code a bit so it could work with both issues and PRs.

@gotmax23 gotmax23 changed the title Add Github Action to label PRs owned by the SC Add Github Action to label issues and PRs Jul 14, 2023
@gotmax23
Copy link
Collaborator Author

gotmax23 commented Jul 14, 2023 •
edited
Loading

Note: someone will need to go into https://github.com/ansible/ansible-documentation/settings/actions and make sure Require approval for first-time contributors who are new to Github is set.

Disregard. See #118 (comment).

@gotmax23
Copy link
Collaborator Author

Force pushed to remove an unused TypeVar.

@samccann samccann mentioned this pull request Jul 18, 2023
Closed
samccann
samccann approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't comment on code but approach lgtm.

@samccann samccann merged commit 0c56c51 into ansible:devel Jul 25, 2023
@samccann
Copy link
Contributor

Explaining the triage label:
1 - I look at open issues with the label - remove the label, add any other labels and add to project board. Might put in enough details to turn it into a good first issue as that gets us a lot of help from community.
2. I look at open PRs with the label - remove the label, review/merge or comment to move the PR along.
3. PRs or issues closed w/o removiing the label is fine. I don't look at closed items for that label.

gotmax23 added a commit to gotmax23/ansible-documentation that referenced this pull request Jul 25, 2023
@gotmax23
Add Github Action to label issues and PRs (ansible#118)
68d58f5
This was referenced Jul 25, 2023
Merged
Merged
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this pull request Jul 25, 2023
@gotmax23
Add Github Action to label issues and PRs (ansible#118)
5f8d40a
@gotmax23 gotmax23 mentioned this pull request Jul 25, 2023
Merged
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this pull request Jul 25, 2023
@gotmax23
Add Github Action to label issues and PRs (ansible#118)
f03bd4e
gotmax23 added a commit that referenced this pull request Jul 25, 2023
@gotmax23
[stable-2.15] Add Github Action to label issues and PRs (#167)
f189b38 
* Add Github Action to label issues and PRs (#118)

* labeler: welcome new contributors

Fixes: #69

* labeler: improve logging

* labeler: add --authed-dry-run flag

Some data such as author_association is only available to authenticated API
users. This helps with testing.

* ci labeler: fix `Print event information` step (#166)

* labeler: fix log() type annotations (#165)

print() coerces any object to a str.
gotmax23 added a commit that referenced this pull request Jul 25, 2023
@gotmax23
[stable-2.14] Add Github Action to label issues and PRs (#168)
0f0e15b 
* Add Github Action to label issues and PRs (#118)

* labeler: welcome new contributors

Fixes: #69

* labeler: improve logging

* labeler: add --authed-dry-run flag

Some data such as author_association is only available to authenticated API
users. This helps with testing.

* ci labeler: fix `Print event information` step (#166)

* labeler: fix log() type annotations (#165)

print() coerces any object to a str.
gotmax23 added a commit that referenced this pull request Jul 25, 2023
@gotmax23
[stable-2.13] Add Github Action to label issues and PRs (#169)
9a74089 
* Add Github Action to label issues and PRs (#118)

* labeler: welcome new contributors

Fixes: #69

* labeler: improve logging

* labeler: add --authed-dry-run flag

Some data such as author_association is only available to authenticated API
users. This helps with testing.

* ci labeler: fix `Print event information` step (#166)

* labeler: fix log() type annotations (#165)

print() coerces any object to a str.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gotmax23 @samccann @felixfontein