Select a windows reference module

[dagwieers]

ISSUE TYPE

• Docs Pull Request

COMPONENT NAME

win_service

ANSIBLE VERSION

v2.3

SUMMARY

As discussed in #20505 we would like to point from the documentation to
a module we choose as the reference module for Windows.

I picked win_service and cleaned it up to the best of my abilities.
I also added check-mode support as an example.

Let the bikeshedding begin !

[dagwieers]

So, let me start off by pointing out that:

• This module does not have any -type set for any parameter. (Fixed with win_service: support for Automatic (Delayed Start) #20124)
• The module does not have any extended documentation, but let us first agree on the module/logic/semantics first and then add the proper code comments.
• This PR will also include documentation updates pointing to this module, as well as providing a list of best practices (including pointing to powershell.ps1 to see what functionality is already provided).

[ansibot]

cc @chrishoffman
click here for bot help

[gundalow]

win_service integration tests are failing, needs_revision

[jborean93]

@dagwieers @ilpianista I was hoping to get all out changes to win_service in before the next release but it seems like we have 3 different pull requests going on at the same time;

• one to update to newer module standards (this one)
• one to add delayed start to the start_mode (win_service: support for Automatic (Delayed Start) #20124)
• one to add in more options and get status of service (Win service rewrite #19143)

I am happy to modify my pull request to add in all your changes instead of trying to make 3 different changes ending up in some merge issues but wanted to get your thoughts first. Are you happy for me to do so or would we just want to get a free for all :)

[dagwieers]

@jborean93 You are right after reviewing #19143 it makes no sense to keep this around. I'll be reviewing your PR.