Wrap CLI Passwords with AnsibleUnsafeText, ensure unsafe context is not lost during encode/decode #63351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Convert CLI provided passwords to text initially, to
prevent unsafe context being lost when converting from bytes->text during
post processing of PlayContext. This prevents CLI provided passwords from
being incorrectly templated (CVE-2019-14856)
Update
AnsibleUnsafeText
andAnsibleUnsafeBytes
to maintain unsafe context by overriding
.encode
and.decode
. Thisprevents future issues with
to_text
,to_bytes
, orto_native
removing the unsafe wrapper when converting between string types
(CVE-2019-14856)
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION