This repository has been archived by the owner on May 23, 2024. It is now read-only.
Add SystemJobTemplate#launch and the SystemJob class #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @syncrou |
This will allow us to trigger a system job template manually and return the created system job. https://bugzilla.redhat.com/show_bug.cgi?id=1560478
carbonin
force-pushed
the
add_launch_for_system_job_templates
branch
from
7ed2a10
to
f8c63b1
Compare
|
Some comments on commit carbonin@f8c63b1 spec/system_job_template_spec.rb
|
|
Checked commit carbonin@f8c63b1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Apr 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to trigger a system job template manually and return the created system job.
@bdunne please review
https://bugzilla.redhat.com/show_bug.cgi?id=1560478