Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Accessing nodes for workflow jobs #109

Merged
merged 2 commits into from
Jun 25, 2018

Conversation

jameswnl
Copy link
Contributor

No description provided.

@jameswnl
Copy link
Contributor Author

@miq-bot add_labels enhancment

@miq-bot
Copy link
Collaborator

miq-bot commented Jun 20, 2018

@jameswnl Cannot apply the following label because they are not recognized: enhancment

@jameswnl
Copy link
Contributor Author

@bzwei @lfu @tinaafitz See if this works for you

@bzwei
Copy link
Contributor

bzwei commented Jun 21, 2018

Looks promising. Thanks @jameswnl

@jameswnl
Copy link
Contributor Author

@miq-bot add_labels wip, enhancement

@miq-bot miq-bot changed the title Accessing nodes for workflow jobs [WIP] Accessing nodes for workflow jobs Jun 22, 2018
@gmcculloug gmcculloug self-assigned this Jun 22, 2018
@gmcculloug
Copy link
Contributor

@jameswnl Any ETA on getting tests passing here?

@jameswnl
Copy link
Contributor Author

@gmcculloug this is just weird, it is passing on my local and my travis https://travis-ci.org/jameswnl/ansible_tower_client_ruby/jobs/394753888
Any suggestion will be welcome

@miq-bot
Copy link
Collaborator

miq-bot commented Jun 23, 2018

Checked commits jameswnl/ansible_tower_client_ruby@7b8849a~...5b47007 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
11 files checked, 199 offenses detected

spec/support/mock_api/workflow_job.rb

spec/support/mock_api/workflow_job_node.rb

@miq-bot
Copy link
Collaborator

miq-bot commented Jun 23, 2018

...continued

@jameswnl jameswnl changed the title [WIP] Accessing nodes for workflow jobs Accessing nodes for workflow jobs Jun 23, 2018
@jameswnl
Copy link
Contributor Author

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Jun 23, 2018
@gmcculloug gmcculloug merged commit ad842d5 into ansible:master Jun 25, 2018
@lfu
Copy link
Contributor

lfu commented Jun 28, 2018

@bdunne Please release a new gem. ManageIQ/manageiq-providers-ansible_tower#103 depends on this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants