little improvements

[AlexanderZagaynov]

avoid redundant redirects

Currently, base resource paths got requested without trailing slashes in addresses.
It leads so such lines in the logs:

INFO -- : get https://example.com/api/v2/config
INFO -- Status: 301
INFO -- : get https://example.com/api/v2/config/
INFO -- Status: 200
INFO -- : get https://example.com/api/v2/inventories
INFO -- Status: 301
INFO -- : get https://example.com/api/v2/inventories/
INFO -- Status: 200

This commit eliminates useless redirect hops.

unhide url of not found resource

Ease 404-related errors debugging.

[miq-bot]

Checked commits AlexanderZagaynov/ansible_tower_client_ruby@319263f~...33ce058 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 0 offenses detected
Everything looks fine. 👍

[AlexanderZagaynov]

@bdunne @jameswnl please review

[jameswnl]

@bdunne can you take a look?

[jrafanie]

@AlexanderZagaynov this change will force VCR cassettes to be manually sed/changed or we'll have to re-record them for the ansible provider. This is because we previously recorded gets for config which will now be config/ and likewise for all collections.

[AlexanderZagaynov]

@jrafanie makes sense. I also noticed one more place with missing trailing slash:

ansible_tower_client_ruby/lib/ansible_tower_client/api.rb

Line 23 in 5ec38ba

JSON.parse(get("me").body).fetch_path("results", 0, "username")

[jrafanie]

@AlexanderZagaynov did you want to get that change in before we merge/release so we can re-record or sed/awk the vcr cassettes only once?

[jrafanie]

@AlexanderZagaynov Ruby 2.5 support doesn't need to happen today or tomorrow.. it can wait until we have all of our changes we want into the gem. If so, please open a PR so we can try releasing a gem version next week. Thanks!

[AlexanderZagaynov]

did you want to get that change in before we merge/release so we can re-record or sed/awk the vcr cassettes only once?

if you mean that me/ redirect, I've prepared a new PR for this, mentioned above.

Ruby 2.5 support doesn't need to happen today or tomorrow.. it can wait until we have all of our changes we want into the gem. If so, please open a PR so we can try releasing a gem version next week. Thanks!

done :)