Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force_boot rabbit if mnesia exists #5316

Closed
wants to merge 1 commit into from
Closed

Force_boot rabbit if mnesia exists #5316

wants to merge 1 commit into from

Conversation

grahamneville
Copy link

SUMMARY

related #5314

tells rabbit to force_boot if mnesia database already exists

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • Installer
AWX VERSION
ADDITIONAL INFORMATION

helm/charts#13485

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@shanemcd
Copy link
Member

I don't love the idea of adding more inline scripts here. Is there a reason not to add it to the startup script in the container? I see you linked to it in the referenced issue.

@grahamneville
Copy link
Author

grahamneville commented Nov 13, 2019

Adding it directly in to launch.sh on the container (by editing the Dockerfile) isn't possible as we won't know the exact directory name created inside /var/lib/rabbitmq/mnesia/ for that pod. This is why we use the ${RABBITMQ_NODENAME} kubernetes var.

Another way to do this is to add it as a configmap and mount it as a volume over the top of launch.sh.
If that's preferred I'll alter the PR.

P.S. https://github.com/ansible/awx-rabbitmq doesn't look to contain the latest code for 3.7.15.

@shanemcd
Copy link
Member

This is why we use the ${RABBITMQ_NODENAME} kubernetes var.

It is available inside of the container as an environment variable. This could be solved with a conditional in the launch script that detects when it is set.

Another problem with this approach is that our downstream images are not based on Alpine.

P.S. https://github.com/ansible/awx-rabbitmq doesn't look to contain the latest code for 3.7.15.

It is the same code, but I ran RABBITMQ_VERSION=3.7.15 make docker-build. I will update the default variable in the Makefile. Thanks for bringing that to my attention.

@grahamneville
Copy link
Author

Closing, replaced with #5317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants