Ansible Big PR review days & Office Hours

[gundalow]

Ask not what your community can do for you, ask what you can do for your community!

What are we doing and why?

Ansible is a very popular project by any metric. Our awesome community contributes lots of Pull Requests (PRs) every month. Unfortunately, the volume of incoming PRs means contributors often have to wait a looong time for PRs to be merged, or even reviewed. We want to change that.

The Core Team and Community at large is starting various initiatives under the Contributor Experience umbrella to help address some of the root causes that slow down quality PRs from being merged into Ansible.
We dedicate one day a month to doing a big community review. We hope you can join in!

What we are trying to achieve

• To give potential new community members a place to learn and experiment with Ansible's review process and get feedback
• Improve the process and documentation by getting feedback from you
  • Feedback from people starting their journey with open source is particularly important to us as it helps to identify and improve complicated processes and documentation.
  • People that have been contributing for a while have already built up this knowledge and have forgotten the "pain of getting started"
• Give PRs some love
• Identify PRs that could be merged or closed
• Help PRs that are not covered by one of the existing Ansible Working Groups, and therefore may otherwise fall through the cracks

How

• Using a few (to be defined) GitHub searches we will go through PRs and:

  • Provide feedback, which is useful to the PR author
  • Provide testing feedback, which will help maintainers know if it can be merged
  • Merge if good
  • Close, if not needed

• For collections we will be focusing on

  • community.general
  • community.network
  • community.aws

When

• Thursday 29th November 2018 from 0900 UTC till late
• Wednesday 19th December 2018 from 0900 UTC till late
• Tuesday 3rd September from 1000UTC til late
• Thursday 19th September from 1000UTC til late
• Thursday 14th November from 1400UTC til late
• Wednesday 17th June from 1400UTC til late
• Tuesday 1st December 2020 1500UTC
• Thursday 17th December 2020 In my timezone, and calendar invitation

Add to your calendar by clicking the Add to Calendar in the above links

What do I need

• A GitHub account
• A bit of spare time
• IRC client to connect to #ansible-community (see note below about registering)
• Add an I'll be there comment to this issue
• Before you start:
  • Read Ansible's Code of Conduct
• If you have a bit more time, the following guides can help. If not just ask during the meeting.
  • Skim read Ansible's Contributing Guide - makes it easier to find content later
  • Read the draft How to do reviews at Ansible document - During the session, as a group, this document will be updated.
  • Read Ansible coding guidelines
  • Skim read Ansible's Module guidelines
  • Want to know more about how to contribute to Ansible, have a look at our on-demand webinar and slides how to make Ansible community contributions.

Even if you are new to contributing to Ansible, this is an excellent opportunity to get involved!

Our IRC channels may require you to register your nickname. If you receive an error when you connect, see Freenode’s Nickname Registration guide for instructions.

[gundalow]

Given some discussion in #ansible-devel today, it was proposed that we should do PR review days fortnightly to help get the PR backlog under control.

Looking at the last three months for ansible/ansible:

• 908 PRs created
• 830 PRs merged (or closed without merging)
• Difference: 78/month

So if we can process another 80 PRs/month then we can keep the backlog stead (or better yet decreasing) [1]

.

• Alternate between different days of the week to give people a reasonable chance of attending
• Publicise the dates well in advance (ie just set the dates for the next n-months)
• Work through different GitHub PR queries each time, so give a reasonable chance of hiting different PRs
• Also advertise this as a dropin place for "can you help review my PR"
• Flesh this into a blog post to help recruit/promote

To avoid too much email spam, how about people vote on this issues:
❤️ This sounds like a good idea, lets see how it works out
and/or
👍 I may be able to attend occasionally to help out.

or
👎 I don't think this is a good idea

Join the discussion in '#ansible-community on Freenode

[1] Yes, yes, I know it doesn't really work like that, and things very from month to month, though the point is that ~10% increase in merge/close rate will let us breakeven

[gundalow]

Starting now in #ansible-community on Freenode IRC

[gundalow]

Starting in just under 3 hours, see you in #ansible-community on Freenode.

[gundalow]

Hi all.
The next PR day will be Wednesday 17th June 2020 from 1400UTC

When

Wednesday 17th June 2020 from 1400UTC

What's this in my Timezone?

Where

#ansible-community on Freenode IRC

What

This will be our first session focusing on the new Community Collections:

• community.general
• community.network
• community.crypto

[gundalow]

Starting now in #ansible-community

[gundalow]

Next two PR days

• Tuesday 1st December 2020 1500UTC In my timezone, and calendar invitation
• Thursday 17th December 2020 In my timezone, and calendar invitation

Please give a 👍 on this issue if you can attend either

[gundalow]

Reminder that this is taking place tomorrow, Tuesday 1st December 2020 1500UTC In my timezone, and calendar invitation

[gundalow]

About to start in #ansible-community on Freenode IRC

[prantikb]

I'll be there

[ggold7046]

Hi,I'm new to open source. Could anyone guide me to good first issues ?

[ggold7046]

@maxamillion , could you help me please ?

[Andersson007]

@ggold7046 hello, apologies for the late reply (long end-of-year PTOs) and welcome to the project!

Please:

• Join us in a real time chat on Matrix at least in #social:ansible.com (say "Hello" there) and #community:ansible.com rooms. You can also ask folks there for easyfixes. See the Communication guide for details.
• Take a look at the Contributor path.
• When you find the first issue to fix, if it's about code, take a look at the Quick-start dev guide.
• Any questions? Feel free to ask (better on Matrix).

Thanks for your interest in contributing to ansible!

[maxamillion]

@ggold7046 what @Andersson007 said! (Double apologies for not replying sooner ... I'm still not caught up on email because I took a whole month off for the winter holidays 😄)

[ggold7046]

Hello Adam, I'm looking for document contribution. I don't have any preference though. If you could guide me that would be great.

…

On Thursday, January 26, 2023, Adam Miller ***@***.***> wrote: @ggold7046 <https://github.com/ggold7046> what @Andersson007 <https://github.com/Andersson007> said! (Double apologies for not replying sooner ... I'm still not caught up on email because I took a whole month off for the winter holidays 😄) — Reply to this email directly, view it on GitHub <#407 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXOFZOGBYMB6LJDAJM6MA63WUKFLZANCNFSM4GFWKNHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Andersson007]

@ggold7046 you could take a look at easifixes:

• across multiple collections
• for all other Ansible projects