PostgreSQL community pinboard

[dagwieers]

This has all moved to community.postgres collection repository.

[Andersson007]

@dagwieers , thank you for this invatation! If nobody is reasonably against I'd like to actively lead this group. I hope everything works out.

[dagwieers]

@Andersson007 Great and thanks ! We do allow more than one leading a Working Group, as long as it helps moving forward and engages the community as a whole I support every new idea. There are no strict rules we try to learn as we go with this new concept of technology-related communities.

There's a lot of open PRs to review and open issues to verify, so everyone is welcome to make the upcoming Ansible v2.8 release the best one for PostgreSQL support. We have about one more month to get our act together!

[Andersson007]

Who can explain me a couple of questions about writing and execution of integration tests?

[dagwieers]

@Andersson007 Integration tests live in our tree in test/integration/targets/. I wrote some information about integration tests at: https://github.com/ansible/community/wiki/Reviewing#integration-tests

My integration tests typically look like this: https://github.com/ansible/ansible/blob/devel/test/integration/targets/mso_tenant/tasks/main.yml

Running an integration test is done using:

$ ansible-test integration --allow-unsupported <target-name>

You can add --docker for running tests in a container, read ansible-test integration --help for more information.

[Andersson007]

@dagwieers, thank you for this useful info! I hope it will be useful for all. This is convenient to use docker for this. I tried to run - nothing difficult.
I'm going to try to write tests for all of my new recent modules
and, if success, maybe for existing modules without tests.
Would be better if other contributors from working group help to add this tests for them too.

[antoinell]

Thanks Andrey for working on this. I also started fiddling with docker today. I did a 11.5 miles run today and my energy was spent there. I noticed all the useful comments you wrote on ansible/ansible#50568 <ansible/ansible#50568> and I hope to get started implementing this slowly. My current work does not use postgresql so I need to get to run postgresql in docker first to do some exploratory research such as finding which query gives the options of a tablespace in case one is working on an existing tablespace and the code needs to check whether the current options match the options requested by the user. Regards, Antoine

…

On Feb 2, 2019, at 2:14 PM, Andrey Klychkov ***@***.***> wrote: @dagwieers <https://github.com/dagwieers>, thank you for this useful info! I hope it will be useful for all. This is convenient to use docker for this. I tried to run - nothing difficult. I'm going to try to write tests for all of my new recent modules and, if success, maybe for existing modules without tests. Would be better if other contributors from working group help to add this tests for them too. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#435 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAckbGC5JoiIsv85Ofjttn8ELlIB6VRaks5vJeN7gaJpZM4acdcw>.

[frittentheke]

Great idea. I've been wondering if a collective push towards a better structure of the PostgreSQL integration would not be sensible.

[dagwieers]

@frittentheke Proposals and ideas are welcome.

One of the first actions of the GitLab WG was to refactor all GitLab modules. IMO it is best we first implement integration tests for the existing code before we refactor these modules.

[Andersson007]

Three modules expect reviews (The last week I added session_role and CI tests for them, improved documentation):
postgresql_ping - ansible/ansible#51477
postgresql_facts - ansible/ansible#51164 (it was epic work, thanks @dagwieers for the review and notices)
postgresql_set - ansible/ansible#51875
postgresql_table - ansible/ansible#52077

[Andersson007]

ansible/ansible#51477 needs to be tried manually. Can anybody run it locally and do shipit if success? (it needs installed psycopg2 as usual)

[Andersson007]

@alikins Hello, I remember you've suggested some help with it but I can't recall where ;) Could you send me a test message to aaklychkov at mail dot ru ? I'd like to ask you a couple of questions about general things.

[Andersson007]

And if anyone needs review or help for his/her postgresql related PRs, please, let me know (you can do it directly by my email written in the message above).

[Andersson007]

Hey, guys. This is the new module PR ansible/ansible#39902.
If the author doesn't mind that somebody rewrite it, is here who want to do it ?
If yes, write it to me directly and here, please.
I'm going to wait a couple of days and start, but I prefer that anybody wants ;) because there are many unmerged new modules from me.
I can help with it.
Of course, the best way is that @jbscalia complete it by himself (I can try to help you if needed)

[sebasmannem]

@Andersson007 : I can have a look at
ansible/ansible#39902 if you like.

[Andersson007]

@sebasmannem , cool, I think if @jbscalia won't answer us before the end of this week, it would be great if you rewrite it ) Thanks!

[Andersson007]

@sebasmannem , also, would be great, if you look at several new modules that are waiting for review.
You can see it here https://github.com/ansible/community/wiki/PostgreSQL.
Waiting for your opinion, notices, shippit, etc )

[Andersson007]

FYI: I've just started a new module called postgresql_vacuum

[Andersson007]

New module postgresql_vacuum is ready for review

[Andersson007]

@AsgerPetersen hey! we have the community pinboard here to communicate and WG where you can find some ideas to implement, add your own, and find things that need reviewing/opinions. You can write yourself into a members table there by editing the wiki page and subscribe here if you like :)
Thank you for the issue reporting and welcome to the Ansible PostgreSQL community!

[Andersson007]

who is interested in not to go to servers when vacuum is needed, please, look at postgresql_vacuum ;)

[Andersson007]

Hello all!
if somebody consider that postgresql_vacuum is useful or useless, please, add your opinion to #57452

My opinion: the point is doing vacuum/analyze/vacuum full remotely by ansible specific module

- name: upload data
  postgresql_copy:
    db: mydb
    from: '/tmp/data.csv'
    dst: mytable
    columns:
    - id
    - name

- name: do vacuum analyze
  postgresql_vacuum:
    db: mydb
    table: mytable
    analyze: yes
    columns:
    - id
    - name

at least the example above looks more elegant and in ansible style than:

- name: do vacuum analyze
  shell: 'psql mydb -c "VACUUM ANALYZE mytable (id, name);"'

For example, 1. I uploaded the data by postgresql_copy module to a table then 2. I'd like to use a specific module for analyze, not shell like above

(Moreover, users don't need to know SQL at all to do it)

[Andersson007]

Hello all! There are three news / suggestions

• I closed postgresql_vacuum PR because there is no activity, thanks all who looked at it, especially @kostiantyn-nemchenko , @sebasmannem and @amenonsen If you want to see it merged, feel free to ping me, I'll reopen it.

• This is an old PR about new module postgresql_publication.
  It looks good and useful.
  I'd like to see it in 2.9 but unfortunately the author didn't reply for my questions.
  Does anyone want to rewrite it keeping @nerzhul as a co-author?
  If yes, please, add a comment here before Wednesday 03.07.2019 or I'll start to do it by myself (or maybe @nerzhul find some time to complete it).

[Andersson007]

• I added a new option called version by #58381 to postgresql_ext module to be able to create extensions of suitable versions (thanks @strk for the idea and the first PR). Would be cool to get the second review (shipit'ed once)

[Andersson007]

Ding Ding Ding, new module postgresql_publication is ready for review

[Andersson007]

Hello all! The Feature Freeze is comming soon, ti will be in less than a week, so it is the last chance to see postgresql_publication merged ansible/ansible#59439 , could anybody please look at this

[Andersson007]

Hey, dear colleagues!
Are there any brave volunteers to look at ansible/ansible#62432, give opinions / solve ? Would be really great if yes :)
waiting for somebody's feedback

[nerzhul]

@Andersson007 yes sorry i miss too many time, thanks for your rewrite. Don't hesitate to write the subscription module to go with it for next release

[Andersson007]

@nerzhul hey, no problem!
agree, the subsctiption and publication would be an exellent pair :)
i recently proposed to write it to another contributor for helping him to sort out all of things and he agreed, will see :)

[Andersson007]

tomorrow i'm starting postgresql_subscription module. Hope it will be done at the end of next week (25.10.2019)

[Andersson007]

postgresql_subscription is available for review ansible/ansible#63661

[Andersson007]

small reminder, ansible/ansible#63661 is ready for review
@tcraxs thanks!

[Andersson007]

hey, dear folks, and i congratulate you on 2.9 was released yesterday!
there are a lot of PRs now - #open prs , I think it does not make sense to create new PRs before the current are merged.
So, really need your help. I'd like to continue despite feeling exhausted sometimes, etc :)
This is our small contribution to not postgres only, i think, but mankind progress in general and the bright future.
Anyway, thank you much for your support, i believe you do all what you can

[Andersson007]

for people who missed something, now all postgres stuff lives in community.general collection

[Andersson007]

FYI: postgres related stuff has been copied to a separate collection called community.postgresql.
The modules will continue to be in community.general for some time, then will be redirected and deprecated.
To not miss anything, don't forget to subscribe to notifications in the new repo:)

[Andersson007]

all new issues/PRs need to be created in community.postgresql, then, if needed, be backported to community.general.

[Andersson007]

Hi all!
A small reminder: postgres-specific stuff has been recently moved to community.postgresql repo (and version 1.0.0 of the new collection has been also published on galaxy).
As i can see, there are only several folks subscribed to the new repo and nobody from our WG...
So, not to miss anything, please start watching the repository (there's a special button for that).
Thanks!

[Andersson007]

FYI:

1. this pinboard has just been created in the dedicated repository PostgreSQL community pinboard ansible-collections/community.postgresql#30
2. PostgreSQL Wiki page has also been moved to that repository https://github.com/ansible-collections/community.postgresql/wiki/PostgreSQL-Working-Group

[Andersson007]

@gundalow feel free to close this issue

[gundalow]

@Andersson007 Thanks done. I've also changed the Ansible/community wiki to point to the new one.

[Andersson007]

@gundalow thanks!