Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1885 #1764 - remove tox-tags #1886

Merged
merged 2 commits into from
Mar 27, 2019

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Mar 27, 2019

  • remove tox-tags,
  • update documentation accordingly,
  • document all tox environments except pur.

Signed-off-by: Fabrice Flore-Thebault [email protected]

PR Type

  • Feature Pull Request

doc/source/testing.rst Outdated Show resolved Hide resolved
doc/source/testing.rst Outdated Show resolved Hide resolved
doc/source/testing.rst Outdated Show resolved Hide resolved
doc/source/testing.rst Outdated Show resolved Hide resolved
doc/source/testing.rst Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@decentral1se
Copy link
Contributor

We can actually take the changes from #1868 (comment) into here or?

@themr0c
Copy link
Contributor Author

themr0c commented Mar 27, 2019

Note (as a reply to @decentral1se): all environments are named in envlist, so removing the environments sections which became empty don't make environments disappear.

@ssbarnea
Copy link
Member

LGTM overall but I wonder why tox -l and tox -a do list both lint and py27-lint... somehow I would like not to see py27-lint listed. Strage that there is nothing in the tox.ini file that should produce it, maybe a bug in tox?

@themr0c
Copy link
Contributor Author

themr0c commented Mar 27, 2019

@ssbarnea I can't reproduce: py27-lint is not in the list:

 fft  (e) molecule-devel   1885-remove-tox-tags  …  externals  themr0c  molecule   tox -l o r-a
lint
py27-ansible25-functional
py27-ansible25-unit
py27-ansible26-functional
py27-ansible26-unit
py27-ansible27-functional
py27-ansible27-unit
py35-ansible25-functional
py35-ansible25-unit
py35-ansible26-functional
py35-ansible26-unit
py35-ansible27-functional
py35-ansible27-unit
py36-ansible25-functional
py36-ansible25-unit
py36-ansible26-functional
py36-ansible26-unit
py36-ansible27-functional
py36-ansible27-unit
py37-ansible25-functional
py37-ansible25-unit
py37-ansible26-functional
py37-ansible26-unit
py37-ansible27-functional
py37-ansible27-unit
format-check
doc

@themr0c themr0c force-pushed the 1885-remove-tox-tags branch 4 times, most recently from af0704e to 8f08c57 Compare March 27, 2019 15:41
…ion accordingly; document all tox environments except pur

Signed-off-by: Fabrice Flore-Thebault <[email protected]>
@themr0c
Copy link
Contributor Author

themr0c commented Mar 27, 2019

Maybe I should revert back to this one:

tox -e $(tox -l | grep functional | paste -d, -s -)

This version appears to be not very functional:

tox -e py{27,35,36,37}-ansible{25,26,27}-unit

It appears to be not compatible with {posargs} in:

commands =
    unit: pytest test/unit/ --cov={toxinidir}/molecule/ --no-cov-on-fail # {posargs}
    functional: pytest test/functional/ {posargs}

I get this error:

ERROR: file not found: py37-ansible27-unit

ERROR: InvocationError for command '/home/.ecryptfs/src/externals/themr0c/molecule/.tox/py37-ansible26-unit/bin/pytest test/unit/ --cov=/home/.ecryptfs/src/externals/themr0c/molecule/molecule/ --no-cov-on-fail py37-ansible27-unit' (exited with code 4)

And if I remove the {posargs}, only one environment is tested.

I am curious to know what the recommended way to invoke tox would be in our situation.

Does someone have any clue ?

@themr0c
Copy link
Contributor Author

themr0c commented Mar 27, 2019

single quotes !!!

tox -e 'py{27,35,36,37}-ansible{25,26,27}-unit'

Signed-off-by: Fabrice Flore-Thebault <[email protected]>
@webknjaz webknjaz merged commit e94f543 into ansible:master Mar 27, 2019
@decentral1se
Copy link
Contributor

<3

webknjaz pushed a commit that referenced this pull request Apr 10, 2019
PR #1886 by @themr0c 

Fixes #1885
Fixes #1764

Signed-off-by: Fabrice Flore-Thebault <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants