Add yamllint to install_requires #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WDYT @webknjaz? |
webknjaz
reviewed
May 13, 2019
decentral1se
force-pushed
the
bugfix/add-yamllint-install-requires
branch
from
80ba6f0
to
a0e0dbc
Compare
webknjaz
approved these changes
May 13, 2019
Closed
|
CI failure unrelated. Please see #2042. |
This is required in the run time and was discovered not present when installing the package as can be seen in the report from ansible#2012. We now include this in our `install_require` list and manage the bounds directly to ensure we have a working default linter.
decentral1se
force-pushed
the
bugfix/add-yamllint-install-requires
branch
from
a0e0dbc
to
9add8bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required in the run time and is suddenly not present when installing the package as can be seen in the report from #2012. We now include this in our
install_requirelist and manage the bounds directly to ensure we have a working default linter.