Pass merged configuration to provisioner playbooks #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now, molecule_yml variable in create/destroy playbooks contained only values from the scenario molecule YAML file. This made it a bit awkward to share common platforms definitions in different scenarios. Changes in this commit replace the direct access to the scenario molecule configuration with the merged one. When the inventory and Ansible configuration files are written to the disk, merged configuration is also stored in the ephemeral directory of the scenario currently being acted upon. Signed-off-by: Tadej Borovšak <[email protected]>
|
@tadeboro can you post a link to a place where you use this feature? It would make easier to test. |
|
This is the PR that demonstrates what we wanted to do: sensu/sensu-go-ansible#32 Up until now, we only tested against latest Sensu docker image. Now that we wanted to add more platforms into the mix, adding them to every scenario became too painful to ignore. Also, here is the link to the CI error that we get: https://circleci.com/gh/sensu/sensu-go-ansible/472?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
ssbarnea
approved these changes
Sep 14, 2019
|
@tadeboro thanks! Very useful addition, I also hope you will document it later. Feel free to contribute more to molecule, I am really looking to get more active contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, molecule_yml variable in create/destroy playbooks contained only values from the scenario molecule YAML file. This made it a bit awkward to share common platforms definitions in different scenarios.
Changes in this commit replace the direct access to the scenario molecule configuration with the merged one. When the inventory and Ansible configuration files are written to the disk, merged
configuration is also stored in the ephemeral directory of the scenario currently being acted upon.
Note: This is a simpler implementation of #2193 and should fix #1423
PR Type