Temporarily limit setuptools version #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix for failing CI is @ #2349 (comment). This has to be merged first though for that to pass. |
This was referenced Oct 7, 2019
LukeShortCloud
approved these changes
Oct 8, 2019
|
Thanks @ekultails (and nice to see you around here again)! I would love to see this bug reported but I don't have the energy to track it now. I'll go ahead and merge this and get a green build on #2354. |
|
Glad to be back! @decentral1se I guess we'll just keep an eye on it and revisit it later. Thanks again for the patch! |
|
I am inclined to believe is linked to pypa/setuptools#1869 maybe is time to obliterate the entire setup.py file, even if this risks of breaking install from source on old python versions. As long we assure we keep installation from wheel working it should be ok. |
ssbarnea
added
the
test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2350.
In the absence of any answers right now, let's keep the ball rolling with this temporary fix.